id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
5729	LibRAS is broken with the NF	Francesco Casella	Per Östlund	"Please compare the coverage report of {{{LibRAS}}} between the [https://libraries.openmodelica.org/branches/master/LibRAS/LibRAS.html OF] and [https://libraries.openmodelica.org/branches/newInst/LibRAS/LibRAS.html NF]. The OF flattens 8/10 and simulates 5/10, the NF flattens 0/10.

Maybe there are problems with the source code, but I guess it's mostly NF issues.

For example, compiling [https://libraries.openmodelica.org/branches/newInst/LibRAS/files/LibRAS_LibRAS.Culture.SSCulture_V.err LibRAS.Culture.SSCulture_V] with the NF gives:
{{{
[LibRAS/Culture/PartialCulture.mo:14:3-14:140:writable] Error: 
Variable loss not found in scope PartialCulture.
}}}
but the [https://github.com/FishSim/LibRAS/blob/fca9de50a484a2213f3ca1b39e275c237c471688/LibRAS/Culture/PartialCulture.mo#L14 line in question] contains 
{{{
  parameter Waste.WasteData waste = Waste.WasteData(fish=fish, feed=feed, loss=loss) ""WasteData record"" annotation(choicesAllMatching=true);
}}}
and the [https://github.com/FishSim/LibRAS/blob/fca9de50a484a2213f3ca1b39e275c237c471688/LibRAS/Culture/Waste.mo#L4 definition of WasteData] contains the [https://github.com/FishSim/LibRAS/blob/fca9de50a484a2213f3ca1b39e275c237c471688/LibRAS/Culture/Waste.mo#L32 line]
{{{
  parameter Real loss = 0.1 ""Feed loss factor"";
}}}

@perost, can you please check if those issues are real?

Thanks!"	defect	closed	high	1.16.0	New Instantiation		invalid