OMEdit does not update models when submodels are changed

[Francesco Casella]

Try this experiment with OMEdit.

1. Create a model A which contains some components (e.g., a step source block and a first order system block), but lacks some required equations (e.g., the connection between the source output and the first order system input).
2. Create a model B and drag an instance of A in it.
3. Check model B: one missing equation is reported.
4. Get back to A and fix it (e.g., connect source and first order system).
5. Get back to B and check it: one missing equation is still reported.
6. Only if some changes are done to B (e.g., the icon of the instance of A is moved in the diagram), OMEdit will actually register the changes made to A at step 4., and report a balanced system.

This is a very serious bug, because the internal state of the GUI is at time inconsistent with the internal state of the omc process running in the background and doing all the model processing work.

This bug is probably also related to #2845.

Thanks to Andrea Bartolini for reporting the problem.

[Martin Sjölund]

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

[Adeel Asghar]

Fixed in r23367.

[massimo ceraolo]

Maybe a further enhancement to the fix of this ticket can be done.

Try this:
1) create a model A that uses a model B
2) modify size and/or position of the string "%name" of model B
3) switch back to model A.

At this point model A should already contain the resized and/or moved name.
Currently, Om r23377 it does not. More in general, it looks like any change in the icon of a model (model B in the example above) icon is not immediately transferred in the models that use it.

[Adeel Asghar]

True. I know this. I won't call this a bug but instead something which I have not implemented (because I didn't get enough time :)). Can you create a new ticket for it? Thanks.

[Andrea Bartolini]

With the packages the problem is still present.
I'm working with the linux version (nightly build - r23584), you can try this test:

1) create a new package P, save and close it
2) create a model M into the package P, save and close it
3) re-open the package P: the model M is not shown.... if you now modify the package P and save it then the model M will be lost.

This is a big problem, because it is easy to loose models by this way...

[Andrea Bartolini]

The same patology is present also if you choose to save a package in multiple files.

Test case:
1) create a new package P1 at root level, deselect the "save content in one file" option and save. The file package.mo is created on disk into the folder P1
2) create a new package P2 into the package P1 and save it. The folder "P2" is created on disk into the folder P1 but the file package.mo on disk is not updated. If you now unload the model then the package P2 will be "lost".

This makes impossible to work with multiple file libraries with OMEdit...

[Christoph <buchner@…>]

Regarding multi-file packages, #2676 is probably connected.

[Martin Sjölund]

Milestone changed to 1.9.3 since 1.9.2 was released.

[Martin Sjölund]

Moved to new milestone 1.9.4

[Adeel Asghar]

This issue has now been fixed in a development branch ​https://github.com/adeas31/OMEdit/tree/indentation for OpenModelica 1.9.4 final release.

[Adeel Asghar]

The fix is now available via the nightly build.

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Milestone renamed