getComponentAnnotations should merge the constrainedby annotation with the component annotation

[Adeel Asghar]

getComponentAnnotations returns empty annotation for the component if constrainedby is used.

[Adrian Pop]

Hmm, there seems to be an issue with the way we parse Modelica grammar here:

element :
  import_clause | extends_clause | 
  [ redeclare ] [ final ] [ inner ] [ outer ]
  ( ( class_definition | component_clause) | 
    replaceable ( class_definition | component_clause) [constraining_clause comment])

component_clause:
type_prefix type_specifier [ array_subscripts ] component_list

component_list :
  component_declaration { "," component_declaration }

component_declaration :
  declaration [ condition_attribute ] comment

Seems that the annotation end up as the comment for the constrainedby clause.

loadString("model M
  type N = Real;
  replaceable N n1 constrainedby Real annotation(choicesAllMatching=true,Placement(visible = true, transformation(origin = {-30, 42}, extent = {{-10, -10}, {10, 10}}, rotation = 0)));
end M;");
getErrorString();
getComponentAnnotations(M);
getErrorString();

[Adrian Pop]

Seems that Modelica allows you to write:

replaceable T1 a[2] annotation(1), b[3] annotation(2), c[4] annotation(3) constrainedby T2 annotation(4);

which is a bit weird as constrainedby T2 should be applied to all the components.

[Adrian Pop]

I opened a ticket on MA: ​m:#1689 and we'll see where that gets us.

[Adrian Pop]

This ticket might also apply for short class definitions:

redeclare T = T1 annotation(1) constrainedby T2 annotation(2);

[Adrian Pop]

Fixed in r25478 for components. Reopen if we need it also for short class definitions.

[Dietmar Winkler]

It doesn't make sense to keep closed ticket in the "Future" milestone that were simply forgotten to assign to the correct milestone in the past.

[Martin Sjölund]

Removing the pre1.9.4 milestone in favor of 1.9.4.