OMEdit crashes or fumbles up the formatting when duplicating classes or copying and pasting text within the same package

[Francesco Casella]

Consider the attached .mo file, which contains a package A with a class M. Open the package with OMEdit.

Select M and duplicate it outside package A. Everything works nicely.

Create a new class N inside package A. Then, copy the second line from the code of class A.M and paste it within A.N. Then save A.N. The formatting is changed to some flavour of omc liking, and it will keep on changing to that forever, every time the model is saved.

Finally, duplicate model A.M inside package A as A.P. Then double click on A.P to open it. OMEdit crashes.

[Francesco Casella]

Test package

[Francesco Casella]

See also #3606, which reports the same situation on a different test case.

[Francesco Casella]

The first problem was fixed in ​https://github.com/OpenModelica/OpenModelica/commit/b1e94adfd88825501d06c74aba48f412baf8d96b

As to the second, when A.M is duplicated inside the package as A.P, the new class also contains the statement within A; (which is weird), but is not saved when the save button is hit, nor does it appear in the package if selecting A.

[Martin Sjölund]

@Adeel: The problem here is that OMEdit calls diffModelicaFileListings on manual changes in the text layer. It must never do this as it prevents the user from making whitespace changes.

[Adeel Asghar]

Replying to sjoelund.se:

@Adeel: The problem here is that OMEdit calls diffModelicaFileListings on manual changes in the text layer. It must never do this as it prevents the user from making whitespace changes.

Fixed in 104cbca/OMEdit.

[Adeel Asghar]

The duplication issue depends on #3577. Once #3577 is fixed this should work automatically.

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Milestone renamed