NF core

[Per Östlund]

This ticket is tracking the progress on the core of the new frontend. The current status is:

Instantiation (Per, Adrian) 50%

Instantiation of long and short class definitions are implemented. Still missing are class extends, enumerations, overloaded functions and partial derivative functions. The handling of equations, algorithms and expressions also needs to be expanded, so far it's mostly just a proof of concept.

Extends (Per) 80%

Support for extends is implemented. More error checking is needed though, e.g. for duplicate elements and illegal class types.

Lookup (Per) 80%

Basic lookup is implemented, both for class names and crefs. Very little error checking is done beyond "name could not be found" though. Some more lookup functions will likely be needed for e.g. inner/outer.

Modifiers (Per) 60%

Support of modifiers on components, extends clauses and class modifiers is implemented, more testing is needed.

Redeclare (Per) 50%

Only very basic redeclare of components is implemented, more work is needed for redeclare of classes, merging of modifiers, constraining type, etc.

Imports (Per) 25%

Basic support for qualified imports is implemented, unqualified imports still remains. It's also only possible to import classes at the moment, and not components. Some way of marking elements as imported is also needed, currently they are just inserted into the importing class as they are.

Conditional Components (Per)

No support for conditional components implemented.

Inner/Outer (Adrian)

No support for Inner/Outer is implemented at all so far, but the new instance tree structure should make this fairly straightforward.

Functions (Adrian, Peter) 5%

Partial support for functions. Instantiation and typing of functions is implemented. Only positional arguments are supported currently. Prefixing is not yet handled correctly. Some way of storing functions during the instantiation (reuse function table from "old new frontend"?) is needed.

Records (Mahder)

No support for records so far, except that the instantiation will instantiate the records as normal classes. Support for record constructors needs to be implemented, and other record things.

Builtin (Per) 5%

So far only support for the basic types and time is implemented. Support for all the builtin functions and other builtin things (e.g. StateSelect, ExternalObject, etc.) needs to be implemented. As much as possible should be implemented via ModelicaBuiltin.

Typing (Mahder, Peter) 60%

Quite a lot of typing is already implemented, but it needs to be expanded to handle all kinds of expressions and so on.

Type Checking (Mahder, Peter, Arun) 10%

Some parts of the type checking module from the "old new frontend" is being used to type check binary expressions at the moment. Everything in NFTypeCheck that's not used is commented out since some of it doesn't compile any more. We need to investigate if more of the old code can be reused, and implement missing/nonreusable parts.

Flattening (Per) 25%

Expansion of array bindings is currently broken and need to be fixed. Subscripting needs to be improved, and the module in general needs to be expanded to keep up with the phases before it.

[Francesco Casella]

Still some problems with component modifiers. Running the following test script

loadString("
package P
  model A
    parameter Real p;
  end A;
  model B
    parameter Real q = 2;
    A a1(p = q);
  end B;
  model C
    parameter Real q = 2;
    A a1(p = q);
    A a2(p = q);
  end C;
end P;
");
setCommandLineOptions("-d=newInst");
instantiateModel(P.B);
instantiateModel(P.C);

returns

true
true
"class B
  parameter Real q = 2;
  parameter Real a1.p = q;
end B;
"
""

so for some reason model C is not instantiated at all.

[Per Östlund]

Replying to casella:

Still some problems with component modifiers.

I am well aware of that, and have already fixed this particular issue locally a while ago. At the moment I'm not really interested in bug reports though, the new instantiation is not ready for public testing yet.

[Francesco Casella]

Replying to perost:

At the moment I'm not really interested in bug reports though, the new instantiation is not ready for public testing yet.

Q1: Can you give a reasonable estimate of when this will be possible?

Q2: Is the interface towards the other tasks of Phase 2 already stabilized? If not, when will it reasonably be?

[Per Östlund]

Replying to casella:

Q1: Can you give a reasonable estimate of when this will be possible?

No

Q2: Is the interface towards the other tasks of Phase 2 already stabilized? If not, when will it reasonably be?

Maybe

[Per Östlund]

Class modifiers have been implemented now, but needs more testing.

[Francesco Casella]

The test case reported in comment:4 now produces the expected result

[Francesco Casella]

However, instantiating P.S in the attached test case still fails

[Per Östlund]

Replying to casella:

However, instantiating P.S in the attached test case still fails

It works fine for me, are you using the latest nightly build?

[Francesco Casella]

Replying to perost:

Replying to casella:

However, instantiating P.S in the attached test case still fails

It works fine for me, are you using the latest nightly build?

I thought so, but I wasn't. With OpenModelica-v1.11.0-dev-288-g2ccad20-64bit, it works fine for me also :)