Opened 8 years ago
Closed 19 months ago
#4551 closed defect (fixed)
Do not allow connection of different connector types
| Reported by: | Owned by: | Adrian Pop | |
|---|---|---|---|
| Priority: | high | Milestone: | 1.21.0 |
| Component: | OMEdit | Version: | |
| Keywords: | Cc: | Adrian Pop, Martin Sjölund |
Description
In the actual version of OMEdit it is possible to, e.g., connect a rotational to an electrical connector or connect a signal connector to a thermal connector. This does not make sense and shall not be allowed.
Attachments (1)
Change History (18)
by , 8 years ago
| Attachment: | Connections.png added |
|---|
comment:1 by , 8 years ago
It is even possible to connect to a connector that should not be visible. for instance connecting an electric connector to the thermal connector of a resistor for which useHeatPort=false
follow-up: 3 comment:2 by , 8 years ago
| Cc: | added |
|---|
AFAIR we use to have this check but then dropped for #2450.
We need to instantiate the model which leads to other issues as well so we simply allow the user to make connections and then show the errors the model is simulated.
Maybe Adrian or Martin has some better ideas.
comment:3 by , 8 years ago
AFAIR we use to have this check but then dropped for #2450.
If, with a reasonable programming effort, it is possible to forbid unacceptable connections, in my opinion this should be pursued.
It would help students and beginners to avoid trivial mistakes, and help us teachers to promote OM better.
In case you decide to allow optionally incorrect connections, for me this option should not be the default.
comment:4 by , 8 years ago
I agree, that students often run into problems by connecting the wrong components. It were therefore very helpful in education to not allow connection between non-matching connectors.
comment:5 by , 7 years ago
| Milestone: | Future → 1.12.0 |
|---|---|
| Resolution: | → duplicate |
| Status: | new → closed |
See #4337.
comment:6 by , 7 years ago
I don't think that this is duplicate of 4337.
May I ask you to reopen this? Just to keep trace of the discussion here and of the difference between this and #4337.
comment:7 by , 7 years ago
I don't see a difference between the two.
A connection of different connector types is indeed an invalid connection, right?
comment:8 by , 7 years ago
I guess what @ceraolo meant was that the discussion in this ticket is also relevant. I've added a reference to this ticket to #4337
comment:9 by , 7 years ago
Adeel,
Sorry for awfully tampering with your comment. I didn't realise that I was modifying it!
comment:10 by , 7 years ago
| Milestone: | 1.12.0 → 1.13.0 |
|---|---|
| Resolution: | duplicate |
| Status: | closed → reopened |
@ceraolo I do agree with you that the description on the both tickets are different buy maybe at the compiler level just a single fix is needed to close both tickets.
I am reopening this ticket so we don't miss out the valuable discussion done here.
comment:11 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | reopened → assigned |
comment:13 by , 5 years ago
| Milestone: | 1.14.0 → 1.16.0 |
|---|
Releasing 1.14.0 which is stable and has many improvements w.r.t. 1.13.2. This issue is rescheduled to 1.16.0
comment:15 by , 4 years ago
| Milestone: | 1.17.0 → 1.18.0 |
|---|
Retargeted to 1.18.0 because of 1.17.0 timed release.
comment:17 by , 19 months ago
| Milestone: | → 1.21.0 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Image showing connections not be allowed