Opened 5 years ago

Closed 5 years ago

#5588 closed defect (fixed)

Deleting submodel crashes OMEdit

Reported by: massimo ceraolo Owned by: Adeel Asghar
Priority: blocker Milestone: 1.14.0
Component: OMEdit Version: v1.14.0-dev-nightly
Keywords: Cc:

Description

Steps to reproduce:

  • load and open Test
  • open RL_Q
  • delete QSensor from Test; now a crossed red square box appears in RL_Q instead of qMeas
  • delete the red box; the connecting lines referred to that box are not deleted
  • delete (using key "del") one of the remaining connecting lines previously connecting to qMeas

=> OMEDIT CRASHES

Tested with OMEdit connected to OpenModelica v1.14.0-dev-26583-g96cf577415 (64-bit)

Attachments (1)

Test.mo​ (7.6 KB ) - added by massimo ceraolo 5 years ago.

Download all attachments as: .zip

Change History (7)

by massimo ceraolo, 5 years ago

Attachment: Test.mo​ added

comment:1 by Francesco Casella, 5 years ago

Priority: critical → blocker

Let's see if we can push this in 1.14.0, OMEdit should never crash.

comment:2 by massimo ceraolo, 5 years ago

The issue here is that when we delete a res-box its connecting lines are not deleted (they should).

comment:3 by Adeel Asghar, 5 years ago

Fixed the crash in [changset:9587ed9/OpenModelica].

Version 0, edited 5 years ago by Adeel Asghar (next)

in reply to:  3 comment:4 by massimo ceraolo, 5 years ago

deleted comment

Last edited 5 years ago by massimo ceraolo (previous) (diff)

comment:5 by massimo ceraolo, 5 years ago

Hope you will also add automatically deletion of connecting lines, as happens when we delete an ordinary block (i.e. not a red-box)

Last edited 5 years ago by massimo ceraolo (previous) (diff)

comment:6 by Adeel Asghar, 5 years ago

Resolution: → fixed
Status: new → closed

Yeah I fixed that yesterday as well but forgot to merge the pull request. See 1097881/OpenModelica.

Note: See TracTickets for help on using tickets.