OMC loads the wrong package

[massimo ceraolo]

The zip file MultifileIssue contains two multi-file packages: "Test_multifile" and "Test_multifile - Copia". The first contains a model named "test", the second contains a model named testNew"
Put the folders in the same disk area. e.g. c:\Work

Then, if we load package.mo from Test_multifile, OMEdit opens the package from "Test_multifile - Copia"!

This is probably due to spaces in names. Tested with Windows

[Adeel Asghar]

Simplified the provided test case and added a script to reproduce the issue.

[Adrian Pop]

I think this is the class loader implemented by @sjoelund.se but I will have a look.

[Adrian Pop]

ClassLoader.mo:149

(mp,name,isDir) := System.getLoadModelPath(id,prios,mps,requireExactVersion);

This one returns name="Test_multifile - Copia" when called with:

System.getLoadModelPath("Test_multifile",{""},"path/to/test/",false);

[Adrian Pop]

The problem is that omc thinks that the part "- Copia" is the version number.
I guess this is the wrong code:
​https://github.com/OpenModelica/OpenModelica/blob/master/OMCompiler/Compiler/runtime/systemimpl.c#L2180

  if (version > 0 && !*versionExtra) {

as version is an array of long so the first condition will *always* true!

[Adrian Pop]

I guess in splitVersion we should init version array with -1 so that we know if the split worked or not. One can have version 0.0.1 so version[0] > 0 is not a good check.
I don't get the code too much so I will let @sjoelund.se fix it if he has time.

[Martin Sjölund]

I'll fix this in ​https://github.com/OpenModelica/OpenModelica/pull/6930 but I will not add a testcase since it seemed random which one was used before.

[Adrian Pop]

Porting it to 1.16:
​https://github.com/OpenModelica/OpenModelica/pull/6939

[massimo ceraolo]

Thank you