Timeline
2022-01-15:
- 20:49 Ticket #6281 (Improvements required for the Buildings 7.0.0 library) closed by
- fixed: All the tickets listed here on Jan 2021 except one (#6196) were fixed …
2022-01-14:
- 16:22 Changeset in OpenModelica [72aca4f]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 3 edits1 add in /
Handle linking of binutil's libbfd with OMEdit.
- The binutils libraries (bfd ...) are not available in the standard locations on MinGW. They are instead in lib/binutils/ folder.
A small cmake find module (Findbinutils.cmake) is added to handle
this. It looks for the library and imports it as target under
- binutil
- namespace.
The libibery lib, which is a dependency of libbfd is also searched
for and added as a dependency.
- 16:22 Changeset in OpenModelica [baeba118]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 1 edit in OMCompiler/CMakeLists.txt
Modify the C flags not the CXX flags. Typo.
- It was modifying the CXX flags instead of the C flags.
- 15:50 Changeset in OpenModelica [cbd0a3c8] by
-
- 3 edits1 add in /
Handle linking of binutil's libbfd with OMEdit.
- The binutils libraries (bfd ...) are not available in the standard locations on MinGW. They are instead in lib/binutils/ folder.
A small cmake find module (Findbinutils.cmake) is added to handle
this. It looks for the library and imports it as target under
- binutil
- namespace.
The libibery lib, which is a dependency of libbfd is also searched
for and added as a dependency.
- 15:50 Changeset in OpenModelica [baa3009] by
-
- 1 edit in OMCompiler/CMakeLists.txt
Modify the C flags not the CXX flags. Typo.
- It was modifying the CXX flags instead of the C flags.
- 13:25 Changeset in OpenModelica [a3c5036c]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 2 edits1 add in /
- Improve the function check to better detect when in a record constructor.
- 12:55 Changeset in OpenModelica [bc031a20] by
-
- 2 edits1 add in /
Fix #8413 properly
- Improve the function check to better detect when in a record constructor.
- 12:22 Changeset in OpenModelica [0aa0fe7c]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 3 edits in /
Revert cref typing fix that doesn't quite work (#8421)
- 11:42 Changeset in OpenModelica [c25778e5] by
-
- 3 edits in /
Revert cref typing fix that doesn't quite work
- 11:41 Changeset in OMSimulator [7e77511] by
-
- in /
Trigger build
- 09:47 Changeset in OpenModelica [4196d44]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 1 edit in OMCompiler/Compiler/NFFrontEnd/NFType.mo
- 09:17 Changeset in OpenModelica [e0142ff7] by
-
- 1 edit in OMCompiler/Compiler/NFFrontEnd/NFType.mo
Partially revert #8414
- 00:47 Changeset in OMSimulator [d164ddc] by
-
- in /
Trigger build
2022-01-13:
- 17:48 Changeset in OpenModelica [ec6160b]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 3 edits1 add in /
Fix typing of crefs in record constructors (#8413)
- 17:34 Changeset in OpenModelica [cd767942]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 3 edits1 add in /
Improve conditional array type handling (#8414)
- Return unknown dimensions for conditional array types in Type.arrayDims instead of an empty array, so at least the number of dimensions is correct (needed by cat).
- Handle type checking when both the expected and the actual type is a conditonal array type.
- 17:13 Changeset in OpenModelica [e693816] by
-
- 3 edits1 add in /
Fix typing of crefs in record constructors
- 17:05 Changeset in OpenModelica [6e1b5f7]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 3 edits in /
Compile the resource files with the GUI executables (#8412)
- The .rc files need to be compiled as part of the exe generation. To get, among other things, the icons.
- 17:00 Changeset in OpenModelica [9e6ad812] by
-
- 3 edits1 add in /
Improve conditional array type handling
- Return unknown dimensions for conditional array types in Type.arrayDims instead of an empty array, so at least the number of dimensions is correct (needed by cat).
- Handle type checking when both the expected and the actual type is a conditonal array type.
- 14:54 Changeset in OpenModelica [0b740e7]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 1 edit1 add in /
Fix homotopy depenency in initial equations (#8408)
- Fix homotopy depenency in initial equations
Don't ignore variables in simplified expression of homotopy
when building adjacency matrix.
- Add test case
- 14:48 Changeset in OpenModelica [4bcd055] by
-
- 3 edits in /
Compile the resource files with the GUI executables
- The .rc files need to be compiled as part of the exe generation. To get, among other things, the icons.
- 14:33 Changeset in OpenModelica [f1d4754c]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 8 edits in /
Remove check for each on scalars (#8409)
- Remove the check that each is not applied to scalars. The check is not correct since it only checks the immediate parent node, and checking it properly is not possible right now since submodifiers do not keep track of their parent modifiers. Since using each on a scalar isn't actually a problem it's better to remove the warning message for now instead of giving false warnings.
Fixes #7777
- 14:06 Changeset in OpenModelica [deddf4ae] by
-
- 8 edits in /
Remove check for each on scalars
- Remove the check that each is not applied to scalars. The check is not correct since it only checks the immediate parent node, and checking it properly is not possible right now since submodifiers do not keep track of their parent modifiers. Since using each on a scalar isn't actually a problem it's better to remove the warning message for now instead of giving false warnings.
Fixes #7777
- 13:39 Changeset in OpenModelica [9a284b76] by
-
- 1 add in testsuite/simulation/modelica/initialization/homotopy7.mos
Add test case
- 13:33 Changeset in OpenModelica [50741cc3]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 1 edit in OMEdit/OMEditLIB/CMakeLists.txt
Add -DUNICODE to compilation of OMEDitLib. (#8410)
- This is added by default by qmake as far as I can tell. So the code assumes it is set always. Set it for CMake as well.
The relevant effect for us is that PROCESSENTRY32 will be overridden
to PROCESSENTRY32W if the define is present.
- 13:12 Changeset in OpenModelica [7d19077] by
-
- 1 edit in OMEdit/OMEditLIB/CMakeLists.txt
Add -DUNICODE to compilation of OMEDitLib.
- This is added by default by qmake as far as I can tell. So the code assumes it is set always. Set it for CMake as well.
The relevant effect for us is that PROCESSENTRY32 will be overridden
to PROCESSENTRY32W if the define is present.
- 12:42 Changeset in OpenModelica [80cce20]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 1 edit in OMEdit/OMEditLIB/Animation/ExtraShapes.cpp
Make sure C math constants are set before using them
- cmath/math.h constants are sometimes not set if _USE_MATH_DEFINES is not set before including cmath/math.h.
- Make sure the define comes at the top of the file so that the header is not included indirectly (by other headers) without the define.
- 12:42 Changeset in OpenModelica [fe2593e]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 20 edits in /
Check for _WIN32 instead of WIN32.
- WIN32 is not defined by the compilers. _WIN32 is. WIN32 is defined by MinGW in a convenience header that seems to be included by most system headers. However if you do the check before you include any file this will not work.
We can manually define WIN32 in a config header if _WIN32 is defined.
However, it is the same issue if we are not including the config header
everytime before we check for WIN32.
2022-01-12:
- 23:21 Changeset in OpenModelica [7560ec9] by
-
- 1 edit in OMCompiler/Compiler/BackEnd/BackendDAEUtil.mo
Fix homotopy depenency in initial equations
Don't ignore variables in simplified expression of homotopy
when building adjacency matrix.
- 19:01 Changeset in OpenModelica [7ed91e8] by
-
- 1 edit in OMEdit/OMEditLIB/Animation/ExtraShapes.cpp
Make sure C math constants are set before using them
- cmath/math.h constants are sometimes not set if _USE_MATH_DEFINES is not set before including cmath/math.h.
- Make sure the define comes at the top of the file so that the header is not included indirectly (by other headers) without the define.
- 19:01 Changeset in OpenModelica [12badbb] by
-
- 20 edits in /
Check for _WIN32 instead of WIN32.
- WIN32 is not defined by the compilers. _WIN32 is. WIN32 is defined by MinGW in a convenience header that seems to be included by most system headers. However if you do the check before you include any file this will not work.
We can manually define WIN32 in a config header if _WIN32 is defined.
However, it is the same issue if we are not including the config header
everytime before we check for WIN32.
- 15:28 Changeset in OMSimulator [1aea83b] by
-
- in /
Trigger build again
- 15:23 Changeset in OpenModelica [d997137] by
-
- 2 edits in /
[WIP] Test windows build with CMake.
- See if there are differences between local machine and jenkins.
- 15:22 Changeset in OMSimulator [cf7486f] by
-
- in /
Trigger build
- 14:58 Changeset in OpenModelica [284d7292]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 4 edits1 move in /
Rename OMSimulator.mo to OMSimulatorExt.mo (#8404)
- Rename OMSimulator.mo to OMSimulatorExt.mo
- This is to avoid conflicting includes between the generated OMSimulator.h (from OMSimulator.mo) and the OMSimulator.h from OMSimulator itself (the public header of OMSimulator)
- Remove workaround added for the conflicting headers.
- 14:30 Changeset in OpenModelica [8f35791] by
-
- 1 edit in OMEdit/OMEditLIB/CMakeLists.txt
Remove workaround added for the conflicting headers.
- 14:15 Changeset in OpenModelica [72ef2825] by
-
- 3 edits1 move in OMCompiler/Compiler
Rename OMSimulator.mo to OMSimulatorExt.mo
- This is to avoid conflicting includes between the generated OMSimulator.h (from OMSimulator.mo) and the OMSimulator.h from OMSimulator itself (the public header of OMSimulator)
- 13:14 Changeset in OpenModelica [06f963d]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 1 edit in OMCompiler/Compiler/FrontEnd/NFSCodeDependency.mo
Handle inverse in dependency analysis (#8403)
- 13:00 Changeset in OpenModelica [48083f09]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 2 edits in OMCompiler/Compiler
Silence parentheses-equality warning for clang. (#8402)
- The code generated from MetaModelica files contains a lot of ((a==b)) as a result of the codegen process. Disable the warning since they are harmless anyway.
- This has been the case for the normal makefile compilations for quite some time.
- Add some comments about the reasons behind and usage of bootstrapped omc (bomc)
- 12:44 Changeset in OpenModelica [5cb495bc] by
-
- 1 edit in OMCompiler/Compiler/FrontEnd/NFSCodeDependency.mo
Handle inverse in dependency analysis
- 12:16 Changeset in OpenModelica [ac31ef5] by
-
- 2 edits in OMCompiler/Compiler
Silence parentheses-equality warning for clang.
- The code generated from MetaModelica files contains a lot of ((a==b)) as a result of the codegen process. Disable the warning since they are harmless anyway.
- This has been the case for the normal makefile compilations for quite some time.
- Add some comments about the reasons behind and usage of bootstrapped omc (bomc)
- 11:44 Changeset in OpenModelica [72026fe]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 3 edits in /
Fix importing of OMSimulatorLib for Windows. (#8401)
- It was written assuming just Linux. Down to the .so extension.
- It is now improved for MinGW. Including importing the corresponding dll import lib.
- For MSVC an error is issued and configuration terminated for now.
- Some minor cleanup for OMParser related uses.
2022-01-11:
- 22:50 Changeset in OpenModelica [55a74623] by
-
- 3 edits in /
Fix importing of OMSimulatorLib for Windows.
- It was written assuming just linux. Down to the .so extension.
- It is now improved for MinGW. Including impporting the corresponding dll import lib.
- For MSVC an error is issued and configuration terminated for now.
- Some minor cleanup for OMParser related uses.
- 17:05 Changeset in OpenModelica [aed8f074]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 4 edits1 add in /
Improve typing of sum(A) and product(A) (#8400)
- Use custom polymorphic types to define sum/product and remove the custom type checking for them. This has the side-effect of giving a proper error for sum/product of a scalar instead of failing for various reasons later in the compiler.
- 16:59 Changeset in OpenModelica [4e7b6fe]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 1 edit in OMCompiler/Compiler/CMakeLists.txt
Export all symbols from libOpenModelicaCompiler. (#8399)
- On Windows we need explicitly tell the dll to export all symbols.
It is not so good that we have to export all symbols. However, OMEdit
uses some of the functions in the lib directly and we have no way of
marking specific MetaModelica functions for exporting.
- 16:24 Changeset in OpenModelica [365d6c1b] by
-
- 4 edits1 add in /
Improve typing of sum(A) and product(A)
- Use custom polymorphic types to define sum/product and remove the custom type checking for them. This has the side-effect of giving a proper error for sum/product of a scalar instead of failing for various reasons later in the compiler.
- 16:20 Changeset in OpenModelica [fdf426dd]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 2 edits2 adds in /
Don't type outer components (#8398)
- Outer components may be partial and/or contain e.g. structural parameters without bindings, so it might not be possible to type them. It's also not necessary to type them since they're removed from the flat model anyway.
Fixes #4908
- 15:53 Changeset in OpenModelica [6a81edd3] by
-
- 2 edits2 adds in /
Don't type outer components
- Outer components may be partial and/or contain e.g. structural parameters without bindings, so it might not be possible to type them. It's also not necessary to type them since they're removed from the flat model anyway.
Fixes #4908
- 15:40 Changeset in OpenModelica [2909120] by
-
- 1 edit in OMCompiler/Compiler/CMakeLists.txt
Export all symbols from libOpenModelicaCompiler.
- On Windows we need explicitly tell the dll to export all symbols.
It is not so good that we have to export all symbols. However, OMEdit
uses some of the functions in the lib directly and we have no way of
marking specific MetaModelica functions for exporting.
2022-01-10:
- 16:19 Changeset in OpenModelica [d1bee64]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 2 edits1 add in /
Improve subscripting of if-expressions (#8396)
- If the branches of an if-expression can't be subscripted because they have different dimensions, just subscript the whole if-expression instead.
Fixes #8341
- 16:00 Changeset in OpenModelica [e47fb56]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 21 edits1 move in OMCompiler/Compiler
Rename GC.mo to GCExt.mo. (#8395)
- Done to avoid conflicting names between the generated GC.h (from the .mo) file and the gc.h from 3rdParty/gc.
Affects case insensitive OSs (GC.h vs gc.h) like most Windows setups.
It was working fine on linux.
- 15:46 Changeset in OpenModelica [70524f5] by
-
- 2 edits1 add in /
Improve subscripting of if-expressions
- If the branches of an if-expression can't be subscripted because they have different dimensions, just subscript the whole if-expression instead.
Fixes #8341
- 15:19 Changeset in OpenModelica [90c6eac] by
-
- 21 edits1 move in OMCompiler/Compiler
Rename GC.mo to GCExt.mo.
- Done to avoid conflicting names between the generated GC.h (from the .mo) file and the gc.h from 3rdParty/gc.
Affects case insensitive OSs (GC.h vs gc.h) like most Windows setups.
It was working fine on linux.
- 14:58 Changeset in OpenModelica [eb90919]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 2 edits in OMCompiler/Compiler
Fix handling of REAL_CLOCK (#8390)
- Do not put Clock constructor arguments inside previous call,
but still generate local var if necessary.
- No need to update constant interval.
- 12:59 Changeset in OpenModelica [ed824a9]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 5 edits1 add in /
Fix scope when mixing replaceable and inner/outer (#8394)
- When looking for the corresponding inner for an outer instance, use the scope of the original element if it has been redeclared.
Fixes #8389
- 12:29 Changeset in OpenModelica [dad2c58e] by
-
- 5 edits1 add in /
Fix scope when mixing replaceable and inner/outer
- When looking for the corresponding inner for an outer instance, use the scope of the original element if it has been redeclared.
Fixes #8389
- 12:05 Changeset in OpenModelica [bdf6959] by
-
- 2 edits in OMCompiler/Compiler
Fix handling of REAL_CLOCK
- Do not put Clock constructor arguments inside previous call,
but still generate local var if necessary.
- No need to update constant interval.
- 12:00 Changeset in OpenModelica [102cf6e]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 3 edits1 add in /
Check for negative dimensions later (#8393)
- Move the check for negative dimensions from typing to flattening, so it's done after deleted conditional components have been removed.
Fixes #8374
- 11:28 Changeset in OpenModelica [f8bb283] by
-
- 3 edits1 add in /
Check for negative dimensions later
- Move the check for negative dimensions from typing to flattening, so it's done after deleted conditional components have been removed.
Fixes #8374
- 10:58 Changeset in OpenModelica [d469b93]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 4 edits in OMCompiler/Compiler/NFFrontEnd
Handle fill in ExpandExp (#8391)
- Expand fill calls in ExpandExp.
- Move the implementation in Ceval.evalBuiltinFills to a more generic Expression.fillArgs function, since the functionality is used in several places in the compiler.
- 10:31 Changeset in OpenModelica [1e95cdd] by
-
- 4 edits in OMCompiler/Compiler/NFFrontEnd
Handle fill in ExpandExp
- Expand fill calls in ExpandExp.
- Move the implementation in Ceval.evalBuiltinFills to a more generic Expression.fillArgs function, since the functionality is used in several places in the compiler.
2022-01-09:
- 03:33 Changeset in OpenModelica [a499198]maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by
-
- 13 edits in /
Use choice comment in dropdown #7488 (#8382)
- parse the choice using the antlr4 OMParser to fetch the comment
- populate the dropdown with the choice comment instead of the full redeclare
- todo: do not add the choicesAllMatching if there are choices (or put it on a flag)
- fix TestChoices.mo to be valid Modelica
- rename libomcparseantlr4 to libOMParser to make it more clear where it comes from
- 03:02 Changeset in OpenModelica [b25ded8d] by
-
- 13 edits in /
Use choice comment in dropdown #7488
- parse the choice using the antlr4 OMParser to fetch the comment
- populate the dropdown with the choice comment instead of the full redeclare
- todo: do not add the choicesAllMatching if there are choices (or put it on a flag)
- fix TestChoices.mo to be valid Modelica
- rename libomcparseantlr4 to libOMParser to make it more clear where it comes from
