Opened 14 years ago

Closed 4 years ago

Last modified 4 years ago

#1428 closed defect (fixed)

inner/outer functions not supported

Reported by: Per Östlund Owned by: Adrian Pop
Priority: high Milestone: 1.16.0
Component: New Instantiation Version:
Keywords: Cc: Per Östlund

Description

We do not support inner/outer functions yet, which causes models such as these to fail:

partial function gravityInterface //example from Fritzson's book, p.177
  input Real r[3] "position";
  output Real g[3] "gravity acceleration";
end gravityInterface;

function uniformGravity
  extends gravityInterface;
  algorithm 
  g := {0, -9.81, 0};
end uniformGravity;

function pointGravity
  extends gravityInterface;
  parameter Real k=1;
protected 
  Real n[3];
algorithm 
  n := -r/sqrt(r*r);
  g := k/(r*r) * n;    
end pointGravity;

model Particle
  parameter Real m = 1;
  outer function gravity = gravityInterface;
  Real r[3](start = {1,1,0}) "position";
  Real v[3](start = {0,1,0}) "velocity";
equation 
  der(r) = v;
  m*der(v) = m*gravity(r);
end Particle;

model ParticlesInPointGravity
  inner function gravity = pointGravity(k=1);
  Particle p1, p2(r(start={1,0,0}));       
end ParticlesInPointGravity;

model ParticlesInUniformGravity
  inner function gravity = uniformGravity;
  Particle p1, p2(v(start={0,0.9,0}));    
end ParticlesInUniformGravity;

model ParticleSystem
  ParticlesInPointGravity pP;
  ParticlesInUniformGravity pU;
end ParticleSystem;

Change History (11)

comment:1 by Adrian Pop, 11 years ago

Cc: perost, → perost
Component: Backend
Milestone: 1.9.1
Owner: changed from Per Östlund to Adrian Pop
Status: acceptedassigned

comment:2 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:3 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:4 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:5 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.5

Milestone pushed to 1.9.5

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.51.10.0

Milestone renamed

comment:7 by Martin Sjölund, 8 years ago

Milestone: 1.10.01.11.0

Ticket retargeted after milestone closed

comment:8 by Martin Sjölund, 8 years ago

Milestone: 1.11.01.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:9 by Francesco Casella, 7 years ago

Milestone: 1.12.0Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

comment:10 by Per Östlund, 4 years ago

Component: BackendNew Instantiation
Resolution: fixed
Status: assignedclosed

The new frontend supports inner/outer classes, including functions.

comment:11 by Francesco Casella, 4 years ago

Milestone: Future1.16.0
Note: See TracTickets for help on using tickets.