Opened 14 years ago

Last modified 7 years ago

#1458 reopened defect

Cyclic default-bindings in functions are still accepted

Reported by: Martin Sjölund Owned by: Martin Sjölund
Priority: high Milestone: Future
Component: Frontend Version:
Keywords: Cc: Martin Sjölund, Per Östlund

Description (last modified by Martin Sjölund)

The check should probably be moved to the instantiation of functions (because we fall back to generation of code). We can check for usage of unbound variables in the same place later on...

function f
  output Real y = y;
end f;

model A
  Real y = f();
end A;
function f
  output Real y = y;
end f;

class A
  Real y = 5.79776549334303e-316;
end A;
Error: Cyclically dependent constants or parameters found in scope : {y}

Change History (13)

comment:1 by Martin Sjölund, 12 years ago

Component: Backend
Description: modified (diff)

comment:2 by Martin Sjölund, 10 years ago

Component: BackendFrontend

comment:3 by Martin Sjölund, 10 years ago

Milestone: 1.9.1

comment:4 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:5 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:7 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.5

Milestone pushed to 1.9.5

comment:8 by Martin Sjölund, 9 years ago

Milestone: 1.9.51.10.0

Milestone renamed

comment:9 by Martin Sjölund, 8 years ago

Milestone: 1.10.01.11.0

Ticket retargeted after milestone closed

comment:10 by Martin Sjölund, 8 years ago

Milestone: 1.11.01.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:11 by Francesco Casella, 7 years ago

Resolution: invalid
Status: newclosed

It is unclear to me what the problem is here. Function f is not used in class A. Where should the cyclic dependency come from?

comment:12 by Martin Sjölund, 7 years ago

Description: modified (diff)
Resolution: invalid
Status: closedreopened

That's the code from the flat Modelica. The output is now:

function f
  output Real y = y;
end f;

class A
  Real y = f();
end A;
[/home/marsj/tmp/a.mo:1:1-3:6:writable] Error: Cyclically dependent constants or parameters found in scope : {y} (ignore with -d=ignoreCycles).

But translation still continues...

comment:13 by Francesco Casella, 7 years ago

Milestone: 1.12.0Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

Note: See TracTickets for help on using tickets.