OMEdit: Clickable error messages

[Martin Sjölund]

Simulation failed for model: abc
[abc.mo:2:3-2:15:writable] Error: Type mismatch in equation r=\"x\" of type Real=String
Error: Error occured while flattening model abc

It should of course be possible to click the abc.mo:2:3-2:15 to instantly modify the sources...

[Adeel Asghar]

Can you test with the latest version? We do have clickable error messages now.

[Per Östlund]

Replying to adeas31:

Can you test with the latest version? We do have clickable error messages now.

I created a simple model with an error in OMEdit:

model M
  Integer i = "fish";
end M;

Instantiating the model pops up a window with the error in it (why not in the message browser?), but the error is not clickable. Simulating the model shows the error in the message browser instead, still not clickable.

[Adeel Asghar]

I just created a new model in OMEdit, switched to text-view, pasted your code and clicked on simulate. I get a clickable error message. See the attached image error.png

[Martin Sjölund]

It is only clickable if the model has not been saved to disk. If you save it, you just get unclickable text:

[2] 17:18:28 Translation Error
[/home/martin/tmp/M.mo: 2:3-2:21]: Type mismatch in binding i = "fish", expected subtype of Integer, got type String.

[Per Östlund]

Here's how it looks for me.

[Per Östlund]

Replying to sjoelund.se:

It is only clickable if the model has not been saved to disk.

OMEdit refuses to simulate a model for me unless it's saved to disk.

[Martin Sjölund]

Replying to perost:

OMEdit refuses to simulate a model for me unless it's saved to disk.

You can change that in settings

[Adeel Asghar]

Replying to sjoelund.se:

It is only clickable if the model has not been saved to disk. If you save it, you just get unclickable text:

[2] 17:18:28 Translation Error
[/home/martin/tmp/M.mo: 2:3-2:21]: Type mismatch in binding i = "fish", expected subtype of Integer, got type String.

Yeah for that I need an API which takes the fileName and error location and return me the qualified path since the error could be inside a package.

[Martin Sjölund]

Or you could open the file and show it...

[Adeel Asghar]

Replying to sjoelund.se:

Or you could open the file and show it...

No, that will lead to more problems. Because then people want to update it and simulate and etc. etc.

[Martin Sjölund]

But that's what we want in the end anyway. Why shouldn't you be able to edit a Modelica file in OMEdit?

[Adeel Asghar]

Fixed in r25314.

[Martin Sjölund]

Only sort of working. Loading the following file points to the wrong line number:

model M
  Real r =


1.5;
  Integer i = "fish";
end M;

[Adeel Asghar]

#1760

[Dietmar Winkler]

It doesn't make sense to keep closed ticket in the "Future" milestone that were simply forgotten to assign to the correct milestone in the past.

[Martin Sjölund]

Removing the pre1.9.4 milestone in favor of 1.9.4.