Opened 12 years ago

Closed 11 years ago

#1788 closed task (fixed)

Testsuite restructuring

Reported by: Per Östlund Owned by: openmodelicadevelopers@…
Priority: high Milestone: 1.9.1
Component: Build Environment Version: trunk
Keywords: Cc: openmodelicadevelopers@…

Description

Right now there's no real structure to the testsuite, so it should be restructured to make it clearer what is tested. My proposal is the following:

  • flattening
    • libraries
      • MSL31
      • MSL221
      • 3rdParty
      • ...
    • language feature tests
      • arrays
      • enums
      • connectors
      • ...
  • simulation Pretty much the same as flattening
  • metamodelica
    • language feature tests (meta)
    • bootstrapping
  • omc features
    • linearization
    • fmi
    • interactive API
    • interactive simulation
    • ...

I think most of our tests can be sorted under one of these four categories, but perhaps I've missed some. Mostly I would like to see mofiles and mosfiles structured better by dividing them into folders based on what language features they are testing, and some of the toplevel folders like expandable and streams should be moved into those folders too. I would also like to see the multibody tests moved into the MSL31 folder, so that it's clear what they are actually testing.

We should also try to standardize tests a bit more. I'm mostly thinking about the library tests we currently have, where there's no standard for what they are named or how many models each test includes. Ideally we should have one testcase for each library model, but that would probably be prohibitively slow due to having to load the library for each test.

While we're at it we should probably go through the failing tests and see if they are still failing, and also check that all tests are accounted for in the makefiles.

Anyway, these are some of my thoughts on how to restructure the testsuite. Discuss!

Change History (6)

comment:1 by Martin Sjölund, 12 years ago

Where do 3rd-party libraries go? (Shared between flattening and simulation)

in reply to:  1 comment:2 by Per Östlund, 12 years ago

Replying to sjoelund.se:

Where do 3rd-party libraries go? (Shared between flattening and simulation)

I guess we should put them somewhere so that they can be shared. So we could e.g. add a libraries folder under the testsuite and put them there.

comment:3 by Martin Sjölund, 11 years ago

Milestone: 1.9.01.9.1

Postponed until 1.9.1

comment:4 by Martin Sjölund, 11 years ago

Cc: openmodelicadevelopers@… added

Is this done? Or are we still unhappy?

comment:5 by Adrian Pop, 11 years ago

I think some models are in the wrong place but is good enough for now.
Also some directory naming seems to be a bit off.

Last edited 11 years ago by Adrian Pop (previous) (diff)

comment:6 by Martin Sjölund, 11 years ago

Resolution: fixed
Status: newclosed

I'll just close it as "fixed". There is no "goodenoughfornow" :)

Note: See TracTickets for help on using tickets.