Stack overflow detection

[Martin Sjölund]

Because OMEdit requires omc to never crash, we need a way to recover from stack overflow.
As far as I can tell there are ways to get the maximum stack size in boehm's GC (since they inspect the stack). If we get the threshold at program start, we can check this in every called function (with rather low overhead).

We would need one thing in the runtime: Another point to longjmp to when we overflow the stack. Same as far matchcontinue; just another stack to add.

In the MetaModelica language, we would need another builtin function (external C would not be enough since it creates a new stack frame even if a macro is called). You call the new builtin operator something like:

(stackOverflow,message) := checkStackOverflow();
if not stackOverflow then
  // stuff that can cause stack overflow
  popStackOverflowBuffer(); // ugly, but I think needed
else
  // error-handling
  // popStackOverflowBuffer() might not be needed
  // it depends how you implement checkStackOverflow()
  // it might be nicer to have the clean-up always called
end if;

It would look nicer if we added special syntax for it, but I think it's fine to simply add an operator. Or maybe even external "C-macro" ;)

As for getting the backtrace so we can add the messages, there are some ways given here:
​http://stackoverflow.com/questions/3151779/how-its-better-to-invoke-gdb-from-program-to-print-its-stacktrace

[Martin Sjölund]

The omc main function now detects overflows. For later we need some additional code to not crash (right now, the main function prints the error and exits).

I did consider some new syntax to be something like:

matchcontinue (a,b,c) /* We could possibly allow match, but it's weird since the stack overflow is a continuation... */
  local
    list<Integer> positions;
    list<String> symbols;
  case (1,2,3) then ...;
  case (_,_,_) then ...;
  case STACKOVERFLOW(positions) /* Requires language extension, but looks nice */
    equation
      symbols = System.backtrace_symbols(positions);
      Error.addMessage(Error.STACK_OVERFLOW, {stringDelimitList(symbols,"\n")});
    then fail();
  case SIGSEGV(positions) /* We could possibly catch more interrupt signals, too */
    equation
      symbols = System.backtrace_symbols(positions);
      Error.addMessage(Error.SIGSEGV, {stringDelimitList(symbols,"\n")});
    then fail();
  else ...; // error-handling as usual
end matchcontinue;

An alternative would be something more explicit:

matchcontinue signal()
  local
    list<Integer> positions;
    list<String> symbols;
  case NOSIGNAL() then ...; /* Regular code */
  case STACKOVERFLOW(positions) /* Requires language extension, but looks nice */
    equation
      symbols = System.backtrace_symbols(positions);
      Error.addMessage(Error.STACK_OVERFLOW, {stringDelimitList(symbols,"\n")});
    then fail();
  case SIGSEGV(positions) /* We could possibly catch more interrupt signals, too. Like SIGUSR1, SIGUSR2 */
    equation
      symbols = System.backtrace_symbols(positions);
      Error.addMessage(Error.SIGSEGV, {stringDelimitList(symbols,"\n")});
      /* Just in case we know that we are calling some external function that might fail */
    then fail();
  else ...; // error-handling as usual
end matchcontinue;

I kinda like the first one. I think it's possible to detect these things and add the required macros in the generated code.

[Martin Sjölund]

Postponed until 1.9.1

[Martin Sjölund]

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

[Martin Sjölund]

Milestone changed to 1.9.3 since 1.9.2 was released.

[Martin Sjölund]

Moved to new milestone 1.9.4

[Martin Sjölund]

This has been fixed by using try-blocks with a special annotation __OpenModelica_stackOverflowCheckpoint=true.

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Milestone renamed