Opened 12 years ago

Closed 4 years ago

Last modified 4 years ago

#2193 closed defect (fixed)

omc accepts undefined identifiers in structural varying models

Reported by: Christoph Höger Owned by: somebody
Priority: high Milestone: 1.16.0
Component: New Instantiation Version: trunk
Keywords: Cc:

Description (last modified by Martin Sjölund)

model IfExpression
  parameter Boolean b = true;
  Integer i = if not b then c else 1;
equation
  assert(i == 1, "The value of i must be 1");
end IfExpression;

The above model should fail (and there should be a testcase to catch that error).

See: m:#1101#comment:5
I suppose it is because of some inlining/constant folding, as the result looks like this:

class IfExpression
  parameter Boolean b = true;
  Integer i = 1;
equation
  assert(i == 1,"The value of i must be 1");
end IfExpression;

omc should certainly do typechecking _before_ evaluation ;).

Change History (12)

comment:1 by Martin Sjölund, 12 years ago

Description: modified (diff)

I have actually worked on this in the past, and see #1736 for a similar issue. Silly old libraries and other things :(

comment:2 by Martin Sjölund, 11 years ago

Milestone: 1.9.01.9.1

Postponed until 1.9.1

comment:3 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:4 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:5 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.5

Milestone pushed to 1.9.5

comment:7 by Martin Sjölund, 9 years ago

Milestone: 1.9.51.10.0

Milestone renamed

comment:8 by Martin Sjölund, 8 years ago

Milestone: 1.10.01.11.0

Ticket retargeted after milestone closed

comment:9 by Martin Sjölund, 8 years ago

Milestone: 1.11.01.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:10 by Francesco Casella, 7 years ago

Milestone: 1.12.0Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

comment:11 by Per Östlund, 4 years ago

Component: FrontendNew Instantiation
Resolution: fixed
Status: newclosed

This gives an error as expected when using the new frontend, since it instantiates the whole model before doing type checking and simplifying if-expressions.

comment:12 by Francesco Casella, 4 years ago

Milestone: Future1.16.0
Note: See TracTickets for help on using tickets.