omc accepts undefined identifiers in structural varying models

[Christoph Höger]

model IfExpression
  parameter Boolean b = true;
  Integer i = if not b then c else 1;
equation
  assert(i == 1, "The value of i must be 1");
end IfExpression;

The above model should fail (and there should be a testcase to catch that error).

See: ​m:#1101#comment:5
I suppose it is because of some inlining/constant folding, as the result looks like this:

class IfExpression
  parameter Boolean b = true;
  Integer i = 1;
equation
  assert(i == 1,"The value of i must be 1");
end IfExpression;

omc should certainly do typechecking _before_ evaluation ;).

[Martin Sjölund]

I have actually worked on this in the past, and see #1736 for a similar issue. Silly old libraries and other things :(