code generation for iteration variable

[Lennart Ochel]

I found some issues using blocks. OpenModelica cannot simulate the model test from the following package.

package bug_2213
  block anyChange "does any entry of a boolean vector change its value?"
    input Boolean vec[:];
    output Boolean anychange;
  algorithm
    anychange:=false;
    for i in 1:size(vec, 1) loop
      anychange:=anychange or change(vec[i]);
    end for;
  end anyChange;

  model test
    Boolean b[3];
    anyChange ac(vec=b);
    Integer i(start=0, fixed=true);
  equation
    b[1] = time > 0.1;
    b[2] = time > 0.2;
    b[3] = time > 0.3;

    when ac.anychange then
      i = pre(i) + 1;
    end when;
  end test;
end bug_2213;

(see also #2213)

The issue is that we get in conflict with the variable name i in the generated c-code.

[Martin Sjölund]

This is an old known bug. Also look in our code for CREF_ITER, which the new frontend is supposed to use in order to avoid conflicts.
If there is a strong need it can probably also be implemented in the old frontend, but it is a lot of work.

[Lennart Ochel]

There is no strong need to fix this for me. I can easily avoid such conflicts in my models ;-). It is just good to know about this.

[Martin Sjölund]

Moved to new milestone 1.9.4

[Martin Sjölund]

Milestone pushed to 1.9.5

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Ticket retargeted after milestone closed

[Martin Sjölund]

Milestone moved to 1.12.0 due to 1.11.0 already being released.

[Francesco Casella]

@perost, can you please comment on comment:1?

[Per Östlund]

Replying to casella:

@perost, can you please comment on comment:1?

I don't know how well the rest of the compiler handles this, but the new instantiation knows which crefs refer to iterators. So we can trivially generate CREF_ITER for iterators if necessary.

[Francesco Casella]

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

[Per Östlund]

It seems this was fixed at some point, the model now compiles without any issues.