Opened 11 years ago

Closed 7 years ago

#2249 closed defect (fixed)

Support new annotation DocumentationClass

Reported by: sjoelund.se Owned by: adeas31
Priority: high Milestone: 1.12.0
Component: OMEdit Version: trunk
Keywords: Cc:

Description

Support new annotation DocumentationClass

Change History (21)

comment:1 Changed 11 years ago by adeas31

  • Resolution set to fixed
  • Status changed from new to closed

Supported in r16478.

comment:2 follow-up: Changed 11 years ago by sjoelund.se

  • Resolution fixed deleted
  • Status changed from closed to reopened

No it's not. It does not open the info layer when I double-click any class inside the DocumentationClass package.

comment:3 in reply to: ↑ 2 Changed 11 years ago by adeas31

Replying to sjoelund.se:

No it's not. It does not open the info layer when I double-click any class inside the DocumentationClass package.

Yeah my mistake. I was opening the text layer instead of info layer.
Note that diagram layer will also be opened with info layer.

comment:4 follow-up: Changed 11 years ago by sjoelund.se

Why? Rather have it full-screen info layer :)

comment:5 in reply to: ↑ 4 Changed 11 years ago by adeas31

Replying to sjoelund.se:

Why? Rather have it full-screen info layer :)

No, the GUI is not designed in that way. Also you can't do the navigation on the info layer then. We had it as full-screen earlier but then changed it the way it is now only to support forward & backward navigation.

comment:6 follow-up: Changed 11 years ago by sjoelund.se

But if I right-click a class and choose view documentation it works as I would expect the preferred view to work. (Right-click->View Class would open the layer and be another action :))

comment:7 in reply to: ↑ 6 Changed 11 years ago by adeas31

Replying to sjoelund.se:

But if I right-click a class and choose view documentation it works as I would expect the preferred view to work. (Right-click->View Class would open the layer and be another action :))

Yes true. This is because you explicitly chosen to view documentation. But when you double click on the class and it has either preferredView as info or DocumentationClass true we open the diagram view and the info layer. I like it this way. If you want to only see the info layer then I can fix it. It not a problem.

comment:8 follow-up: Changed 11 years ago by sjoelund.se

Yes, I think it would be good. Because when I now try to click the documentation I get tons of open models. Not what I want.

Also, ModelicaServices.UsersGuide is not handled (its children do not open documentation)

comment:9 in reply to: ↑ 8 ; follow-up: Changed 11 years ago by adeas31

Replying to sjoelund.se:

Yes, I think it would be good. Because when I now try to click the documentation I get tons of open models. Not what I want.

Sorry, I agreed without thinking a lot. If we only open the documentation view on the double click then there is only one way left to open the other views which "view class" through context menu. I am not going to do this. You have to live with it.

Also, ModelicaServices.UsersGuide is not handled (its children do not open documentation)

Fixed it now. Thanks for the test. I was only checking the root parent and not the immediate parent.

comment:10 in reply to: ↑ 9 ; follow-up: Changed 11 years ago by sjoelund.se

Replying to adeas31:

Sorry, I agreed without thinking a lot. If we only open the documentation view on the double click then there is only one way left to open the other views which "view class" through context menu. I am not going to do this. You have to live with it.

Why? Who wants to modify the code of documentation classes directly? I mean, it is a read-only class...

comment:11 in reply to: ↑ 10 Changed 11 years ago by adeas31

Replying to sjoelund.se:

Replying to adeas31:

Sorry, I agreed without thinking a lot. If we only open the documentation view on the double click then there is only one way left to open the other views which "view class" through context menu. I am not going to do this. You have to live with it.

Why? Who wants to modify the code of documentation classes directly? I mean, it is a read-only class...

You think I only added support for the read-only classes? Also its not only about modifying classes. Users may also want to view them.

comment:12 Changed 11 years ago by sjoelund.se

But they can do that. You need a better way of handling preferredView info. Because opening up useless classes is not much fun.

comment:13 Changed 11 years ago by sjoelund.se

  • Milestone changed from 1.9.0 to 1.9.1

Postponed until 1.9.1

comment:14 Changed 10 years ago by sjoelund.se

  • Milestone changed from 1.9.1 to 1.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:15 Changed 10 years ago by sjoelund.se

  • Milestone changed from 1.9.2 to 1.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:16 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.3 to 1.9.4

Moved to new milestone 1.9.4

comment:17 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.4 to 1.9.5

Milestone pushed to 1.9.5

comment:18 Changed 9 years ago by sjoelund.se

  • Milestone changed from 1.9.5 to 1.10.0

Milestone renamed

comment:19 Changed 8 years ago by sjoelund.se

  • Milestone changed from 1.10.0 to 1.11.0

Ticket retargeted after milestone closed

comment:20 Changed 8 years ago by adeas31

  • Milestone changed from 1.11.0 to 1.12.0

Milestone changed to 1.12.0 since 1.11.0 was released.

comment:21 Changed 7 years ago by adeas31

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in 6b6200/OMEdit.

Note: See TracTickets for help on using tickets.