Opened 11 years ago
Closed 7 years ago
#2249 closed defect (fixed)
Support new annotation DocumentationClass
| Reported by: | Martin Sjölund | Owned by: | Adeel Asghar |
|---|---|---|---|
| Priority: | high | Milestone: | 1.12.0 |
| Component: | OMEdit | Version: | trunk |
| Keywords: | Cc: |
Description
Support new annotation DocumentationClass
Change History (21)
comment:1 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
follow-up: 3 comment:2 by , 11 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
No it's not. It does not open the info layer when I double-click any class inside the DocumentationClass package.
comment:3 by , 11 years ago
Replying to sjoelund.se:
No it's not. It does not open the info layer when I double-click any class inside the DocumentationClass package.
Yeah my mistake. I was opening the text layer instead of info layer.
Note that diagram layer will also be opened with info layer.
comment:5 by , 11 years ago
Replying to sjoelund.se:
Why? Rather have it full-screen info layer :)
No, the GUI is not designed in that way. Also you can't do the navigation on the info layer then. We had it as full-screen earlier but then changed it the way it is now only to support forward & backward navigation.
follow-up: 7 comment:6 by , 11 years ago
But if I right-click a class and choose view documentation it works as I would expect the preferred view to work. (Right-click->View Class would open the layer and be another action :))
comment:7 by , 11 years ago
Replying to sjoelund.se:
But if I right-click a class and choose view documentation it works as I would expect the preferred view to work. (Right-click->View Class would open the layer and be another action :))
Yes true. This is because you explicitly chosen to view documentation. But when you double click on the class and it has either preferredView as info or DocumentationClass true we open the diagram view and the info layer. I like it this way. If you want to only see the info layer then I can fix it. It not a problem.
follow-up: 9 comment:8 by , 11 years ago
Yes, I think it would be good. Because when I now try to click the documentation I get tons of open models. Not what I want.
Also, ModelicaServices.UsersGuide is not handled (its children do not open documentation)
follow-up: 10 comment:9 by , 11 years ago
Replying to sjoelund.se:
Yes, I think it would be good. Because when I now try to click the documentation I get tons of open models. Not what I want.
Sorry, I agreed without thinking a lot. If we only open the documentation view on the double click then there is only one way left to open the other views which "view class" through context menu. I am not going to do this. You have to live with it.
Also, ModelicaServices.UsersGuide is not handled (its children do not open documentation)
Fixed it now. Thanks for the test. I was only checking the root parent and not the immediate parent.
follow-up: 11 comment:10 by , 11 years ago
Replying to adeas31:
Sorry, I agreed without thinking a lot. If we only open the documentation view on the double click then there is only one way left to open the other views which "view class" through context menu. I am not going to do this. You have to live with it.
Why? Who wants to modify the code of documentation classes directly? I mean, it is a read-only class...
comment:11 by , 11 years ago
Replying to sjoelund.se:
Replying to adeas31:
Sorry, I agreed without thinking a lot. If we only open the documentation view on the double click then there is only one way left to open the other views which "view class" through context menu. I am not going to do this. You have to live with it.
Why? Who wants to modify the code of documentation classes directly? I mean, it is a read-only class...
You think I only added support for the read-only classes? Also its not only about modifying classes. Users may also want to view them.
comment:12 by , 11 years ago
But they can do that. You need a better way of handling preferredView info. Because opening up useless classes is not much fun.
comment:14 by , 10 years ago
| Milestone: | 1.9.1 → 1.9.2 |
|---|
This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).
comment:15 by , 10 years ago
| Milestone: | 1.9.2 → 1.9.3 |
|---|
Milestone changed to 1.9.3 since 1.9.2 was released.
comment:20 by , 8 years ago
| Milestone: | 1.11.0 → 1.12.0 |
|---|
Milestone changed to 1.12.0 since 1.11.0 was released.
Supported in r16478.