Opened 11 years ago

Closed 6 years ago

#2340 closed defect (fixed)

Default record binding in constants is not handled correctly

Reported by: Adrian Pop Owned by: Per Östlund
Priority: high Milestone: 2.0.0
Component: New Instantiation Version: trunk
Keywords: Cc:

Description

This appears in the Buildings library.
See attached model.

Attachments (2)

vfr.mo​ (148.3 KB ) - added by Adrian Pop 11 years ago.
vfr.mos​ (208 bytes ) - added by Adrian Pop 11 years ago.

Download all attachments as: .zip

Change History (15)

by Adrian Pop, 11 years ago

Attachment: vfr.mo​ added

by Adrian Pop, 11 years ago

Attachment: vfr.mos​ added

comment:1 by Adrian Pop, 11 years ago

Owner: changed from somebody to Adrian Pop
Status: new → accepted

comment:2 by Adrian Pop, 11 years ago

The problems is as follows:

  record DataRecord 
          extends Modelica.Icons.Record;
          String name;
          Modelica.SIunits.MolarMass MM;
          Modelica.SIunits.SpecificHeatCapacity R;
          Modelica.SIunits.SpecificHeatCapacity cp;
          Modelica.SIunits.SpecificHeatCapacity cv = cp - R;
        end DataRecord;

  constant PerfectGases.Common.DataRecord H2O(
             name = Modelica.Media.IdealGases.Common.SingleGasesData.H2O.name, 
             R = Modelica.Media.IdealGases.Common.SingleGasesData.H2O.R, 
             MM = Modelica.Media.IdealGases.Common.SingleGasesData.H2O.MM, 
             cp = 1860);

cv component is not bound in the H2O binding, but is bound inside the type:

          Modelica.SIunits.SpecificHeatCapacity cv = cp - R;

currently we try to take the binding from the type if is constant, otherwise not
and Inst.makeRecordBinding2 fails.

comment:3 by Martin Sjölund, 11 years ago

Milestone: 1.9.0 → 1.9.1

Postponed until 1.9.1

comment:4 by Martin Sjölund, 10 years ago

Milestone: 1.9.1 → 1.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:5 by Martin Sjölund, 10 years ago

Milestone: 1.9.2 → 1.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.3 → 1.9.4

Moved to new milestone 1.9.4

comment:7 by Martin Sjölund, 9 years ago

Milestone: 1.9.4 → 1.9.5

Milestone pushed to 1.9.5

comment:8 by Martin Sjölund, 9 years ago

Milestone: 1.9.5 → 1.10.0

Milestone renamed

comment:9 by Martin Sjölund, 8 years ago

Milestone: 1.10.0 → 1.11.0

Ticket retargeted after milestone closed

comment:10 by Martin Sjölund, 8 years ago

Milestone: 1.11.0 → 1.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:11 by Francesco Casella, 7 years ago

Milestone: 1.12.0 → Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

comment:12 by Francesco Casella, 7 years ago

Component: Frontend → New Instantiation
Milestone: Future → 2.0.0
Owner: changed from Adrian Pop to Per Östlund
Status: accepted → assigned

comment:13 by Francesco Casella, 6 years ago

Resolution: → fixed
Status: assigned → closed

The corresponding example in the testuite ​Buildings.Fluid.Sensors.Examples.VolumeFlowRate now simulates correctly,

Note: See TracTickets for help on using tickets.