Opened 11 years ago

Closed 9 years ago

Last modified 9 years ago

#2451 closed defect (fixed)

Do not check model while saving

Reported by: roeldeconinck@… Owned by: Adeel Asghar
Priority: high Milestone: 1.9.4
Component: OMEdit Version: trunk
Keywords: Cc:

Description

Saving a model (or library) in OMEdit takes too long. It looks like OMEdit checks the full package before saving the files? This is unnecessary, we can use 'check model' to do that.

Saving a bundle of text files should take a split second, not 15s.

Change History (10)

comment:1 by roeldeconinck@…, 11 years ago

Component: BackendOMEdit
Owner: changed from probably noone to Adeel Asghar
Type: enhancementdefect

comment:2 by Adeel Asghar, 11 years ago

No, we can't do that. We must parse the file before saving it. We need to push the user changes to the AST so that OMEdit can do all the graphics.

comment:3 by roeldeconinck@…, 11 years ago

Can you push those user changes only for the modified models? Now I see the translation of a bunch of models that is not affected by a minimalistic change in a single file.

comment:4 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:5 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:7 by Adeel Asghar, 9 years ago

Status: newaccepted

This issue has now been fixed in a development branch https://github.com/adeas31/OMEdit/tree/indentation for OpenModelica 1.9.4 final release.

comment:8 by Adeel Asghar, 9 years ago

Resolution: fixed
Status: acceptedclosed

The fix is now available via the nightly build.

comment:9 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.4-1.9.x

Milestone renamed

comment:10 by Martin Sjölund, 9 years ago

Milestone: 1.9.4-1.9.x1.9.4

Milestone renamed

Note: See TracTickets for help on using tickets.