Can't run omc built from trunk on OS X

[janssen]

Now I'm getting this:

% omc +s +i=msdfe.nominal msdfe.mo Modelica ModelicaServices
dyld: Library not loaded: @rpath/libcoinmumps.1.4.11.dylib
  Referenced from: /local/open-modelica/bin/../lib/omc/libOpenModelicaFMIRuntimeC.dylib
  Reason: image not found
Trace/BPT trap
% ls -l /local/open-modelica/lib/omc
total 55968
-rw-r--r--  1 wjanssen  admin     3252 Dec 13 10:59 IpInterfacesRegOp.o
-rw-r--r--  1 wjanssen  admin   124804 Dec 13 10:59 IpIpoptApplication.o
-rw-r--r--  1 wjanssen  admin     6188 Dec 13 10:59 IpSolveStatistics.o
-rw-r--r--  1 wjanssen  admin     9612 Dec 13 10:59 IpStdCInterface.o
-rw-r--r--  1 wjanssen  admin     5264 Dec 13 10:59 IpStdFInterface.o
-rw-r--r--  1 wjanssen  admin    32364 Dec 13 10:59 IpStdInterfaceTNLP.o
-rw-r--r--  1 wjanssen  admin   178348 Dec 13 11:00 IpTNLPAdapter.o
-rw-r--r--  1 wjanssen  admin    20336 Dec 13 11:00 IpTNLPReducer.o
-rw-r--r--  1 wjanssen  admin    21828 Dec 13 14:19 MetaModelicaBuiltin.mo
-rw-r--r--  1 wjanssen  admin   137455 Dec 13 14:19 ModelicaBuiltin.mo
-rw-r--r--  1 wjanssen  admin     3680 Aug  9 15:04 ParModelicaBuiltin.mo
drwxr-xr-x  2 wjanssen  admin       68 Dec 13 10:55 emcc
-rw-r--r--  1 wjanssen  admin    68120 Dec 13 10:56 libModelicaExternalC.a
-rwxr-xr-x  1 wjanssen  admin     1038 Dec 13 10:56 libModelicaExternalC.la
-rw-r--r--  1 wjanssen  admin  1271440 Dec 13 10:56 libModelicaStandardTables.a
-rwxr-xr-x  1 wjanssen  admin     1053 Dec 13 10:56 libModelicaStandardTables.la
-rw-r--r--  1 wjanssen  admin    56608 Aug  9 15:09 libOMOCLRuntime.a
-rw-r--r--  1 wjanssen  admin    31096 Oct 24 08:10 libOpenModelicaFMIRuntimeC.a
-rwxr-xr-x  1 wjanssen  admin    29828 Dec 13 14:19 libOpenModelicaFMIRuntimeC.dylib
-rw-r--r--  1 wjanssen  admin   587640 Nov 11 10:33 libOpenModelicaRuntimeC.a
-rwxr-xr-x  1 wjanssen  admin   602840 Dec 13 11:00 libOpenModelicaRuntimeC.dylib
-rw-r--r--  1 wjanssen  admin  1558640 Dec  9 19:33 libSimulationRuntimeC.a
-rwxr-xr-x  1 wjanssen  admin  1405528 Dec 13 14:19 libSimulationRuntimeC.dylib
-rw-r--r--  1 wjanssen  admin   864096 Dec 13 14:19 libantlr3.a
drwxr-xr-x  2 wjanssen  admin       68 Aug 28  2012 libexec
-rw-r--r--  1 wjanssen  admin   717776 Dec 13 14:19 libf2c.a
-rw-r--r--  1 wjanssen  admin     1594 Dec 13 14:19 libf2c.lbc
-rw-r--r--  1 wjanssen  admin     2051 Dec 13 14:19 libf2c.sy
-rw-r--r--  1 wjanssen  admin  2755112 Oct 24 08:09 libfmilib.a
-rwxr-xr-x  1 wjanssen  admin   726668 Dec 13 14:19 libfmilib.dylib
-rwxr-xr-x  1 wjanssen  admin   726668 Dec 13 14:19 libfmilib_shared.dylib
-rw-r--r--  1 wjanssen  admin    70672 Dec 13 11:00 libfmuWrapper.a
-rw-r--r--  1 wjanssen  admin   778688 Dec 13 10:55 libgc.a
-rw-r--r--  1 wjanssen  admin   678760 Dec 13 11:00 libinteractive.a
-rwxr-xr-x  1 wjanssen  admin  2799508 Dec 13 14:19 libipopt.1.9.6.dylib
-rwxr-xr-x  1 wjanssen  admin  2799508 Dec 13 14:19 libipopt.1.dylib
-rwxr-xr-x  1 wjanssen  admin  2799508 Dec 13 14:19 libipopt.dylib
-rw-r--r--  1 wjanssen  admin      852 Dec 13 11:00 libipopt.lai
-rwxr-xr-x  1 wjanssen  admin   596736 Dec 13 10:56 liblis.dylib
-rw-r--r--  1 wjanssen  admin    22528 Dec 13 14:19 libmodparomc.a
-rw-r--r--  1 wjanssen  admin  3954112 Dec 13 14:19 libomcruntime.a
-rw-r--r--  1 wjanssen  admin  2118872 Dec 13 14:19 libomparse.a
% ls -l /local/open-modelica/lib/libcoinmumps.1.4.11.dylib 
-rwxr-xr-x  1 wjanssen  admin  1700816 Dec 13 14:19 /local/open-modelica/lib/libcoinmumps.1.4.11.dylib
%

I think this is due to a missing line in top-level Makefile.common, in the target for build/lib/omc/libipopt.la:

cp -pPR 3rdParty/Ipopt-3.11.6/ThirdParty/Mumps/.libs/*.* build/lib/omc

In fact, I think the lines

	test ! `uname` = Darwin || install_name_tool -id @rpath/libipopt.1.9.6.dylib 3rdParty/Ipopt-3.11.6/lib/libipopt.1.9.6.dylib
	test ! `uname` = Darwin || install_name_tool -id @rpath/libcoinmumps.1.4.11.dylib 3rdParty/Ipopt-3.11.6/lib/libcoinmumps.1.4.11.dylib
	cp -pPR 3rdParty/Ipopt-3.11.6/lib/*.* build/lib/omc
	cp -pPR 3rdParty/Ipopt-3.11.6/include/coin build/include/omc

need to be changed to this:

	-rm -f build/lib/omc/libipopt*
	-rm -rf build/include/omc/include/.svn
	test ! `uname` = Darwin || install_name_tool -id @rpath/libipopt.1.9.6.dylib 3rdParty/Ipopt-3.11.6/Ipopt/src/Interfaces/.libs/libipopt.1.9.6.dylib
	test ! `uname` = Darwin || install_name_tool -id @rpath/libcoinmumps.1.4.11.dylib 3rdParty/Ipopt-3.11.6/ThirdParty/Mumps/.libs/libcoinmumps.1.4.11.dylib
	cp -pPR 3rdParty/Ipopt-3.11.6/Ipopt/src/Interfaces/.libs/*.* build/lib/omc
	cp -pPR 3rdParty/Ipopt-3.11.6/ThirdParty/Mumps/MUMPS/include build/include/omc

[sjoelund.se]

Is this just a make clean issue when updating from one version of the trunk to the new one?
​https://test.openmodelica.org/hudson/view/Mac/job/OpenModelica_OSX_BUILD/ws/OpenModelica-clang/build/lib/omc/ shows that libcoinmumps is in fact installed from a clean checkout. But with an old version of the trunk already compile, the makefiles might not realise this.