Opened 11 years ago
Closed 3 years ago
#2709 closed defect (fixed)
final parameter in ComparisonQuasyStationary.mo
Reported by: | Volker Waurich | Owned by: | Per Östlund |
---|---|---|---|
Priority: | normal | Milestone: | 1.19.0 |
Component: | New Instantiation | Version: | trunk |
Keywords: | final parameter | Cc: | Martin Sjölund, Adrian Pop, Per Östlund, Lennart Ochel, Willi Braun |
Description
Hi,
the parameter simpleSolenoid.coil.N in the model
Modelica.Magnetic.FluxTubes.Examples.SolenoidActuator.ComparisonQuasiStationary.mo
from msl 3.2.
should be declared as a final parameter:
Modelica.Magnetic.FluxTubes.Basic.ElectroMagneticConverter coil(final N=N, i(fixed=true))
but in daelow its not final:
197: simpleSolenoid.coil.N:PARAM()
Change History (17)
comment:1 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → accepted |
comment:2 by , 11 years ago
Cc: | added |
---|
comment:4 by , 11 years ago
Priority: | high → normal |
---|
comment:5 by , 10 years ago
Milestone: | 1.9.1 → 1.9.2 |
---|
This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).
comment:6 by , 10 years ago
Milestone: | 1.9.2 → 1.9.3 |
---|
Milestone changed to 1.9.3 since 1.9.2 was released.
comment:10 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | accepted → assigned |
Some of broken models are now working. The remaining models are:
simulation/libraries/msl32/Modelica.Magnetic.FluxTubes.Examples.SolenoidActuator.ComparisonQuasiStationary.mos simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMEE_Generator_MultiPhase.mos simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMPM_Inverter_MultiPhase.mos simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMR_Inverter_MultiPhase.mos
The issues are the same as before.
comment:12 by , 8 years ago
Milestone: | 1.11.0 → 1.12.0 |
---|
Milestone moved to 1.12.0 due to 1.11.0 already being released.
comment:13 by , 7 years ago
Milestone: | 1.12.0 → Future |
---|
The milestone of this ticket has been reassigned to "Future".
If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.
If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".
In both cases, a short informative comment would be welcome.
comment:14 by , 3 years ago
Milestone: | Future → 1.18.0 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
With the new frontend the parameter is declared as final, so I guess we can consider this fixed.
comment:15 by , 3 years ago
Component: | Frontend → New Instantiation |
---|---|
Milestone: | 1.18.0 → 1.19.0 |
Resolution: | fixed |
Status: | closed → reopened |
comment:16 by , 3 years ago
Owner: | changed from | to
---|---|
Status: | reopened → assigned |
comment:17 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I have committed a fix for this now, but have not enabled it yet since it seems to break some things in the backend. To enable it, simply uncomment the call to InstUtil.propagateModFinal in InstVar.instScalar. These tests needs to be fixed first though: