Opened 10 years ago

Closed 3 years ago

#2709 closed defect (fixed)

final parameter in ComparisonQuasyStationary.mo

Reported by: Volker Waurich Owned by: Per Östlund
Priority: normal Milestone: 1.19.0
Component: New Instantiation Version: trunk
Keywords: final parameter Cc: Martin Sjölund, Adrian Pop, Per Östlund, Lennart Ochel, Willi Braun

Description

Hi,
the parameter simpleSolenoid.coil.N in the model

Modelica.Magnetic.FluxTubes.Examples.SolenoidActuator.ComparisonQuasiStationary.mo

from msl 3.2.
should be declared as a final parameter:

Modelica.Magnetic.FluxTubes.Basic.ElectroMagneticConverter coil(final N=N, i(fixed=true))

but in daelow its not final:

197: simpleSolenoid.coil.N:PARAM()

Change History (17)

comment:1 by Per Östlund, 10 years ago

Owner: changed from somebody to Per Östlund
Status: newaccepted

comment:2 by Per Östlund, 10 years ago

Cc: Lennart Ochel Willi Braun added

I have committed a fix for this now, but have not enabled it yet since it seems to break some things in the backend. To enable it, simply uncomment the call to InstUtil.propagateModFinal in InstVar.instScalar. These tests needs to be fixed first though:

simulation/libraries/msl31/Modelica.Electrical.Machines.Examples.DCSE_Start.mos
  Simulation result not equal for der(dcse.la.i)

simulation/libraries/msl32/Modelica.Magnetic.FluxTubes.Examples.SolenoidActuator.ComparisonQuasiStationary.mos
  Gives a warning about alias set with several free start values. I don't know how bad this is.

simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMEE_Generator_MultiPhase.mos
simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMPM_Inverter_MultiPhase.mos
simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMR_Inverter_MultiPhase.mos
  Error when solving linear system.

simulation/modelica/msl22/Test3PhaseInitOver.mos
  Over-determined initial system has changed, several variables have been replaced 
  with zeros in the printed equation. I don't know if this is an issue or not.

comment:3 by Volker Waurich, 10 years ago

Thanks a lot. I will check the magnetic models.

comment:4 by Volker Waurich, 10 years ago

Priority: highnormal

comment:5 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:6 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:7 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:8 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.5

Milestone pushed to 1.9.5

comment:9 by Martin Sjölund, 9 years ago

Milestone: 1.9.51.10.0

Milestone renamed

comment:10 by Per Östlund, 9 years ago

Owner: changed from Per Östlund to somebody
Status: acceptedassigned

Some of broken models are now working. The remaining models are:

simulation/libraries/msl32/Modelica.Magnetic.FluxTubes.Examples.SolenoidActuator.ComparisonQuasiStationary.mos
simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMEE_Generator_MultiPhase.mos
simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMPM_Inverter_MultiPhase.mos
simulation/libraries/msl32/Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SMR_Inverter_MultiPhase.mos

The issues are the same as before.

comment:11 by Martin Sjölund, 8 years ago

Milestone: 1.10.01.11.0

Ticket retargeted after milestone closed

comment:12 by Martin Sjölund, 8 years ago

Milestone: 1.11.01.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:13 by Francesco Casella, 7 years ago

Milestone: 1.12.0Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

comment:14 by Per Östlund, 3 years ago

Milestone: Future1.18.0
Resolution: fixed
Status: assignedclosed

With the new frontend the parameter is declared as final, so I guess we can consider this fixed.

comment:15 by Francesco Casella, 3 years ago

Component: FrontendNew Instantiation
Milestone: 1.18.01.19.0
Resolution: fixed
Status: closedreopened

comment:16 by Francesco Casella, 3 years ago

Owner: changed from somebody to Per Östlund
Status: reopenedassigned

comment:17 by Francesco Casella, 3 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.