Opened 10 years ago

Closed 4 years ago

Last modified 4 years ago

#2712 closed defect (fixed)

Accessing connector array with dynamic index results in C code compile error

Reported by: Metello <metello@…> Owned by: Lennart Ochel
Priority: normal Milestone: 1.16.0
Component: Code Generation Version: 1.9.0Beta
Keywords: Cc:

Description (last modified by Martin Sjölund)

The simple model below results in bad C code generation (does not compile). It was tested with OpenModelica 1.9.0 (r17628).

The problem seems to be acessing a connector in an array of connections by an index integer variable that changes with time:

cValue = if condition then inConnections[index].value else 0;


model ConnectionArrayBug

  connector RealConn
    Real value;
  end RealConn;

  model ValueSource
    parameter Real value;
    RealConn connection;
  equation
    connection.value = value;
  end ValueSource;

  model BuggedModel
    parameter Integer nConn;
    RealConn inConnections[nConn];
  protected
    Boolean condition;
    Integer index;
    Real cValue;
  equation
    condition = true;
    index = if time > 0.5 then 1 else 2;
    cValue = if condition then inConnections[index].value else 0;
  end BuggedModel;

  ValueSource s1(value = 1);
  ValueSource s2(value = 2);
  BuggedModel m1(nConn = 2);

equation
  connect(s1.connection,m1.inConnections[1]);
  connect(s2.connection,m1.inConnections[2]);
end ConnectionArrayBug;

Change History (12)

comment:1 by Martin Sjölund, 10 years ago

Description: modified (diff)

comment:2 by Martin Sjölund, 10 years ago

Status: newassigned

comment:3 by Martin Sjölund, 10 years ago

Milestone: 1.9.11.9.2

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

comment:4 by Martin Sjölund, 10 years ago

Milestone: 1.9.21.9.3

Milestone changed to 1.9.3 since 1.9.2 was released.

comment:5 by Martin Sjölund, 9 years ago

Milestone: 1.9.31.9.4

Moved to new milestone 1.9.4

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.5

Milestone pushed to 1.9.5

comment:7 by Martin Sjölund, 9 years ago

Milestone: 1.9.51.10.0

Milestone renamed

comment:8 by Martin Sjölund, 8 years ago

Milestone: 1.10.01.11.0

Ticket retargeted after milestone closed

comment:9 by Martin Sjölund, 8 years ago

Milestone: 1.11.01.12.0

Milestone moved to 1.12.0 due to 1.11.0 already being released.

comment:10 by Francesco Casella, 7 years ago

Milestone: 1.12.0Future

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

comment:11 by Per Östlund, 4 years ago

Resolution: fixed
Status: assignedclosed

This seems to have been fixed at some point, the model now successfully simulates.

comment:12 by Francesco Casella, 4 years ago

Milestone: Future1.16.0
Note: See TracTickets for help on using tickets.