Stack overflow in frontend

[Martin Sjölund]

The attached model gives a stack overflow when run through omc.

[Per Östlund]

Minimal model:

package Noise
  block SampleClock
    parameter Real k = .Noise.foo;
  end SampleClock;

  block Noise
    SampleClock sampleClock;
  end Noise;
end Noise;

model Controller
  Noise.Noise noiseModel;
end Controller;

I thought it would be a redeclare issue as usual, but this looks like it could maybe be fixable. I will investigate a bit more and see.

[Per Östlund]

The issue has been "fixed" in r21297, which means that it no longer gets a stack overflow. It now fails because it can't find the variable Noise.Examples.Parts.Modelica_LinearSystems2.Controller.Types.BlockTypeWithGlobalDefault.UseSampleClockOption instead. I'll see if I can figure out why.

[Martin Sjölund]

Maybe they messed up when including LinearSystems2 into the library. (Some import or FQ cref or something perhaps?) I guess you actually had a look though ;)

[Per Östlund]

The issue is that we fully qualify some names by prefixing them with the environment in InstExtends.fixCref, but we don't make them into fully qualified crefs. And since there's a Noise-block in Modelica_LinearSystems2.Controller we find that instead of the Noise-package at top-level. The fix is simple, just fully qualify the names if we prefix them with the environment. Doing so makes the complete model flatten, but of course causes some Media models to fail with stack overflows...

[Martin Sjölund]

Fun as usual :)

[Martin Sjölund]

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

[Martin Sjölund]

Milestone changed to 1.9.3 since 1.9.2 was released.

[Martin Sjölund]

Moved to new milestone 1.9.4

[Martin Sjölund]

Milestone pushed to 1.9.5

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Ticket retargeted after milestone closed

[Martin Sjölund]

Milestone moved to 1.12.0 due to 1.11.0 already being released.

[Francesco Casella]

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

[Martin Sjölund]

I'll mark this as fixed because the original bug was fixed