Revert from previous unclear

[Francesco Casella]

When trying to save a syntactically wrong model in OMEdit, an error window pops up with the following text:

"Problems are found in Modelica Text. Please check the Message Browser for more error specific details". This is perfectly clear.

"For normal users it is recommended to choose Revert from previous. You can also choose Fix errors manually if you want to fix them by your own.". This is totally unclear, confusing and not up to the point.

The most important issue is that it is not at all clear that if you press Revert from previous, you lose all your work since the last time you saved - so, this shouldn't be the default anyway. Second, who are "normal" user? Are they "abnormal" if they are not normal? :)
Third, of course you have to fix errors manually, there is no such thing as automatic error fixing - discarding the previous hour of work or so is a rather extreme way of fixing errors...

Suggestions:

• Change the second sentence to: "You cannot save syntactically wrong Modelica code. If you cannot find the source of the error, you can always revert to the last saved version."
• Put the "Fix error manually" to the left and make it the default choice (no harm is done with this choice!)
• Change the text of the other button to "Revert to last saved version" (note that the correct English is "revert to", not "revert from", despite what other tools claim)

It would also be useful to give the user a third option, namely to "Temporarily save and fix later" - in this case, the previously saved text is not changed, and the new text can be stored in a tool-specific annotation.

[Christoph <buchner@…>]

Good to know! I have not until now realised that this option does a revert to the last saved state, I always thought it's basically an undo of the last change! Probably haven't felt the impact yet because I save quite often.

[Martin Sjölund]

Milestone changed to 1.9.3 since 1.9.2 was released.

[Adeel Asghar]

Well the message is not only shown when you are trying to save the model. It is also shown when you might manually edit the code in the text view and then switch back to diagram view. Therefore, I will use Francesco's suggestions but with the following changes,

• Change the second sentence to: "If you cannot find the source of the error, you can always revert to the last correct version."

Note that i used last correct version because that is what we revert to and not to last saved version.

• Put the "Fix error(s) manually" to the left and make it the default choice (no harm is done with this choice!)
• Change the text of the other button to "Revert to last correct version" (note that the correct English is "revert to", not "revert from", despite what other tools claim)

[Martin Sjölund]

Moved to new milestone 1.9.4

[Francesco Casella]

Replying to adeas31:

Well the message is not only shown when you are trying to save the model. It is also shown when you might manually edit the code in the text view and then switch back to diagram view. Therefore, I will use Francesco's suggestions but with the following changes,

• Change the second sentence to: "If you cannot find the source of the error, you can always revert to the last correct version."

Note that i used last correct version because that is what we revert to and not to last saved version.

• Put the "Fix error(s) manually" to the left and make it the default choice (no harm is done with this choice!)
• Change the text of the other button to "Revert to last correct version" (note that the correct English is "revert to", not "revert from", despite what other tools claim)

Fine for me. Please go ahead with the implementation.

[Adeel Asghar]

This issue has now been fixed in a development branch ​https://github.com/adeas31/OMEdit/tree/indentation for OpenModelica 1.9.4 final release.

[Adeel Asghar]

The fix is now available via the nightly build.

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Milestone renamed