Wrong variability for array reduction

[Adrian Pop]

Flattening this model:

model BadVariability

  package Medium
    constant Boolean singleState = false;
  end Medium;

  parameter Integer nReg(min = 2) = 2;

  model CoilRegister  "Register for a heat exchanger" 
    constant Boolean initialize_p1 = not Medium.singleState;
  end CoilRegister;

  CoilRegister[nReg] hexReg(initialize_p1 = array(i == 1 and not Medium.singleState for i in 1:nReg));
end BadVariability;

gives:

adrpo@ida-liu050 ~/dev/OpenModelica/build/bin/media
$ ../omc +locale=C BadVariability.mo 
Error processing file: BadVariability.mo
[c:/bin/cygwin/home/adrpo/dev/OpenModelica/build/bin/media/BadVariability.mo:13:29-13:101:writable] Error: Component hexReg[2].initialize_p1 of variability CONST has binding false of higher variability PARAM.
Error: Error occurred while flattening model BadVariability

The variability should be constant for the array reduction, not parameter.

This affects some of the building models, see for example:
​https://test.openmodelica.org/libraries/Buildings/files/Buildings.Fluid.HeatExchangers.Examples.WetCoilDiscretizedPerfectGases.err

[Adrian Pop]

Fixed in r24514.

[Dietmar Winkler]

It doesn't make sense to keep closed ticket in the "Future" milestone that were simply forgotten to assign to the correct milestone in the past.

[Martin Sjölund]

No, a reduction with an iterator that is paramter should not be able to assign to a constant. This also has the side-effect of making OM evaluate things like array(1 for i in 1:n) into {} regardless of value of the parameter n. I will revert this changeset since it conflicts with #4550.

[Martin Sjölund]

If necessary for the library (especially old ones), we could have a debug-flag -d=allowAssigningParameterToConstant or something similar which forces evaluation of the parameter and prints a warning (which we could use in the library coverage).

[Francesco Casella]

Works in 1.17.0-dev, in including ​Buildings.Fluid.HeatExchangers.Validation.WetCoilDiscretizedInitializationPerfectGases