Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3444 closed enhancement (fixed)

Add one/two decimal figures to timing reports by Hudson

Reported by: Francesco Casella Owned by: Adrian Pop
Priority: high Milestone: 1.9.4
Component: *unknown* Version: trunk
Keywords: Cc:

Description

Automatic reports such as https://test.openmodelica.org/libraries/MSL_3.2.1/BuildModelRecursive.html show figures in seconds and minutes, without any decimal figure.

This is too coarse for all but the heaviest models. For example, most figures in the MSL 3.2.1 report are rounded down to 0s, which is not very meaningful.

I would suggest to add one/two decimal figures to the seconds measurement, or to add millliseconds (such as 1m20s234ms), as it is more convenient.

Change History (10)

comment:1 by Adrian Pop, 9 years ago

In my opinion we should do this a bit differently. We should generate BuildModelRecursive.xml where we keep all the data and then xlst it to .html so we can change the view as we want.

comment:2 by Martin Sjölund, 9 years ago

Keep in mind that doing xslt from milliseconds to something readable does not look pretty.

comment:3 by Francesco Casella, 9 years ago

I don't have any preference as to how this is implemented (the easier and the more flexible, the better). In fact, IMO even having all the times just in seconds (with two decimal digits) would be just fine.

The only requirement is to increase the resolution below 1 s.

comment:4 by Adrian Pop, 9 years ago

Resolution: fixed
Status: newclosed

Now we display Ns [NNN.NNNN] for all the numbers.
38b8a98c189e173bdb589f29084ccfcfa47c4e07/OMCompiler

comment:5 by Rüdiger Franke, 9 years ago

Resolution: fixed
Status: closedreopened

The new tables resulting from nightly tests are much harder to read than before. Before we had 2-4 lines per test and light borders. Now we have 4-5 lines per test and hard borders. Just compare the old appearance

https://test.openmodelica.org/libraries/history/MSL_3.2.1-2015-09-03.html

with the new one

https://test.openmodelica.org/libraries/history/MSL_3.2.1-2015-09-04.html

The table borders might be needed to better separate the cells containing more information now, but twice as much lines are really bad.

Couldn't the Verification column somehow be reduced to two lines?
For example:

0s 
[0.9152], 
31/143 
signals 
failed

might be reduced to

31/143 
failed

comment:6 by Adrian Pop, 9 years ago

It depends a lot of your X axis resolution :)
For me every test fits in one line.
However, you're right and I'll think about a better way to display this.
I think we should only keep the numbers in [...] and remove the rest.
Then we have the better accuracy and is more homogeneous.

in reply to:  5 comment:7 by Francesco Casella, 9 years ago

Replying to rfranke:

The new tables resulting from nightly tests are much harder to read than before. Before we had 2-4 lines per test and light borders. Now we have 4-5 lines per test and hard borders.

If you use Firefox, just hit Ctrl-minus a couple of times.

However, I agree with Adrian that just reporting seconds with decimals should be just fine. After all, the longest reported times are a few minutes, and nobody has a problem understanding 512 seconds instead of 8m32s.

comment:8 by Adrian Pop, 9 years ago

Milestone: 1.9.31.9.4
Resolution: fixed
Status: reopenedclosed

Fixed in 0e43de59523089663518c567aaa6a78237180679/OMCompiler by just displaying the real numbers with 4 decimal digits.

comment:9 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.4-1.9.x

Milestone renamed

comment:10 by Martin Sjölund, 9 years ago

Milestone: 1.9.4-1.9.x1.9.4

Milestone renamed

Note: See TracTickets for help on using tickets.