Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3466 closed defect (fixed)

OMEdit scrambles up package directory structure

Reported by: Francesco Casella Owned by: Adeel Asghar
Priority: critical Milestone: 1.9.4
Component: OMEdit Version:
Keywords: Cc:

Description

Please consider the attached test package. It contains a directory named Test, which contains package.mo, package.order, A.mo and B.mo (two sub-packages).

OMEdit opens it correctly. However, as soon as I modify something within package A (e.g., add a package constant definition), it does the following weird things:

  • it creates two directories Test/A and Test/B
  • it saves Test/A/package.mo and Test/B/package.mo with the content of the packages (including modifications)
  • it keeps the old Test/A.mo and Test/B.mo files
  • it complains that classes A and B are defined in multiple files

The intended behaviour should be

  • if a package within Test is modified, the modifications should be applied to the existing files
  • if a new package is added to Test (e.g. Test.C), the user should be given a choice between
    • adding it to package.mo
    • adding it as C.mo
    • adding a directory Test/C and then a file package.mo there

Attachments (1)

Test.zip (801 bytes ) - added by Francesco Casella 9 years ago.
Test files

Download all attachments as: .zip

Change History (8)

by Francesco Casella, 9 years ago

Attachment: Test.zip added

Test files

comment:1 by Adeel Asghar, 9 years ago

Isn't it same as #3179.

comment:2 by Francesco Casella, 9 years ago

Owner: changed from Adeel Asghar to Francesco Casella
Status: newaccepted

It is, in fact I looked for something similar in the database but did not use the right search keywords.

I'll attach the test case there.

comment:3 by Francesco Casella, 9 years ago

Owner: changed from Francesco Casella to Adeel Asghar
Status: acceptedassigned

I thought better, the two are related, but are not the same. I am not complaining about the effects of automatic saving, I complain about the effects of intentionally saving the modifications.

comment:4 by Adeel Asghar, 9 years ago

This issue has now been fixed in a development branch https://github.com/adeas31/OMEdit/tree/indentation for OpenModelica 1.9.4 final release.

Last edited 9 years ago by Adeel Asghar (previous) (diff)

comment:5 by Adeel Asghar, 9 years ago

Resolution: fixed
Status: assignedclosed

The fix is now available via the nightly build.

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.4-1.9.x

Milestone renamed

comment:7 by Martin Sjölund, 9 years ago

Milestone: 1.9.4-1.9.x1.9.4

Milestone renamed

Note: See TracTickets for help on using tickets.