Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3480 closed defect (fixed)

Connectors inside top level connector should be a top level connectors too

Reported by: Maksimov Doe Owned by: Maksimov Doe
Priority: high Milestone: 1.9.4
Component: Frontend Version:
Keywords: Cc:

Description

In following example connectors conn1 and conn1.conn2 both should be outside connectors for model Ex.

model Ex
  connector Conn1
    input Integer foo;

    connector Conn2
      input Integer foo;
    end Conn2;
    Conn2 conn2;
  end Conn1;

  Conn1 conn1;
end Ex;

But currently only conn1 is marked as outside:

class Ex
  input Integer conn1.foo;
  Integer conn1.conn2.foo;
end Ex;

Change History (7)

comment:1 by Maksimov Doe, 9 years ago

I have found that problem is function InstVar.stripVarAttrDirection which strips nested connectors directions. It should use ConnectUtil.componentFaceType to detect top level inputs/outputs. Same for function CheckMode.topLevelInput.

comment:2 by Maksimov Doe, 9 years ago

Owner: changed from somebody to Maksimov Doe
Status: newassigned

comment:3 by Maksimov Doe, 9 years ago

Summary: Connector inside Outside connector should be an Outside connector tooConnectors inside top level connector should be a top level connectors too

comment:4 by Adrian Pop, 9 years ago

Resolution: fixed
Status: assignedclosed

comment:5 by Dietmar Winkler, 9 years ago

Milestone: Future1.9.4

Sorting these closed tickets away from "Future". Since they were closed after the last 1.9.3 release, it's very likely that they should have been part of the 1.9.4 release.

comment:6 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.4-1.9.x

Milestone renamed

comment:7 by Martin Sjölund, 9 years ago

Milestone: 1.9.4-1.9.x1.9.4

Milestone renamed

Note: See TracTickets for help on using tickets.