#3480 closed defect (fixed)
Connectors inside top level connector should be a top level connectors too
Reported by: | gossen | Owned by: | gossen |
---|---|---|---|
Priority: | high | Milestone: | 1.9.4 |
Component: | Frontend | Version: | |
Keywords: | Cc: |
Description
In following example connectors conn1 and conn1.conn2 both should be outside connectors for model Ex.
model Ex connector Conn1 input Integer foo; connector Conn2 input Integer foo; end Conn2; Conn2 conn2; end Conn1; Conn1 conn1; end Ex;
But currently only conn1 is marked as outside:
class Ex input Integer conn1.foo; Integer conn1.conn2.foo; end Ex;
Change History (7)
comment:1 Changed 9 years ago by gossen
comment:2 Changed 9 years ago by gossen
- Owner changed from somebody to gossen
- Status changed from new to assigned
comment:3 Changed 9 years ago by gossen
- Summary changed from Connector inside Outside connector should be an Outside connector too to Connectors inside top level connector should be a top level connectors too
comment:4 Changed 9 years ago by adrpo
- Resolution set to fixed
- Status changed from assigned to closed
Fixed in e02e8c9/OMCompiler.
Test added in 49a754d/OpenModelica-testsuite.
comment:5 Changed 9 years ago by dietmarw
- Milestone changed from Future to 1.9.4
Sorting these closed tickets away from "Future". Since they were closed after the last 1.9.3 release, it's very likely that they should have been part of the 1.9.4 release.
comment:6 Changed 8 years ago by sjoelund.se
- Milestone changed from 1.9.4 to 1.9.4-1.9.x
Milestone renamed
comment:7 Changed 8 years ago by sjoelund.se
- Milestone changed from 1.9.4-1.9.x to 1.9.4
Milestone renamed
I have found that problem is function InstVar.stripVarAttrDirection which strips nested connectors directions. It should use ConnectUtil.componentFaceType to detect top level inputs/outputs. Same for function CheckMode.topLevelInput.