Wrong generation of base partitions

[Rüdiger Franke]

The code generated for the following model does not compile due to the attempt to access the not existing previous(dt).

model SID "Single Integrator Discrete-time"
  parameter Real dt = 0.1 "sample time" annotation(Evaluate=true);
  parameter Real p = 1 "gain for input";
  parameter Real y_start = 0 "start value for state";
  Real xd(start = y_start);
  input Real u(start = -2);
  output Real y;
equation
  when Clock(dt) then
    xd = previous(xd) + p * u * dt;
  end when;
  y = hold(previous(xd));
end SID;

The sample rate dt should be constant. Instead omc -s -d=dumpSynchronous SID.mo gives

Base clocks (1)
========================================
1: Clock(previous(dt))[1]

[Lennart Ochel]

see also #3482

[Lennart Ochel]

The example is now compiling. Can one check if the results are correct?

[Lennart Ochel]

Please note: I didn't touched the evaluation of dt. The generated base clock is now defined as follows:

Base partitions (1)
========================================
1: Clock(dt)[1]

[Lennart Ochel]

The results seem to be wrong for the c runtime since xd is zero.
The results are correct for the Cpp runtime.

[Rüdiger Franke]

That's as expected. Thank you!

[Rüdiger Franke]

The clock parameter is not evaluated -- see initial title of this ticket. Take the example:

​https://github.com/OpenModelica/OpenModelica-testsuite/commit/68309ab43da673674cb9a89bccc6e3d8f83c066e

The test declares dt constant. The clock interval must not disappear from modelDescription.xml if changed to a parameter with annotation(Evaluate=true) -- the generation of modelDescription.xml expects an RCONST.

[Martin Sjölund]

Milestone pushed to 1.9.5

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Ticket retargeted after milestone closed

[Martin Sjölund]

Milestone moved to 1.12.0 due to 1.11.0 already being released.

[Francesco Casella]

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.