#3531 closed defect (fixed)
Backend changes from October 27 significantly slow down BranchingDynamicPipes
| Reported by: | Rüdiger Franke | Owned by: | Vitalij Ruge |
|---|---|---|---|
| Priority: | critical | Milestone: | 1.9.4 |
| Component: | Backend | Version: | |
| Keywords: | Cc: | Volker Waurich, Mahder Alemseged Gebremedhin, Willi Braun |
Description
Today's nightly tests report for Modelica.Fluid.Examples.BranchingDynamicPipes a time in the backend of 72.29s:
https://test.openmodelica.org/libraries/history/MSL_3.2.1-2015-10-28.html
It used to be significantly less, e.g. 16.45s yesterday:
https://test.openmodelica.org/libraries/history/MSL_3.2.1-2015-10-27.html
Yesterday's commit messages don't indicate a reason for this increase. Can the backend time be improved again?
Change History (13)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
Since the last commit of vruge lead to the increase in backend time, I would redirect the ticket to him.
comment:3 by , 9 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 9 years ago
| Status: | assigned → accepted |
|---|
comment:5 by , 9 years ago
What is the status of this ticket?
Is it ok to revert the respective commit until the problem will be solved?
comment:6 by , 9 years ago
If I get it right, then it's this commit that causes the slowdown dd7ca6. @vitalij What is the positive impact of this commit? I think if it makes a bunch of models working, then we should not revert it, otherwise it should be fine to revert it for now.
comment:7 by , 9 years ago
| Cc: | added |
|---|
comment:8 by , 9 years ago
The issues is force inlining in
BackendDAECreate->lowerEqn->simplifyAndForceInlineEquationExp
with the combination #3510 we have a big number of expressions.
I will add option(default=false) for inlining function with protected array-variables, which will be ignored inside the dynamicStateSelection.
follow-up: 10 comment:9 by , 9 years ago
| Cc: | added |
|---|---|
| Priority: | high → critical |
There is no improvement after your last commits. On contrary, BranchingDynamicPipes took 74.32 seconds in the backend tonight.
Where does the model force inlining?
After two weeks without solution, can you please consider reverting your changes until the changeset will be complete?
comment:10 by , 9 years ago
Replying to rfranke:
After two weeks without solution, can you please consider reverting your changes until the changeset will be complete?
donerevert.
Note: potential issues is #3556
Where does the model force inlining?
FrondEnd->Inline->forceInlineExp
and is used for example in BackendDAECreate, IndexReduction, ExpressionSolve, ...
I will figure it out and hopefully fix it.