Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3560 closed enhancement (fixed)

Testing of Modelica_Synchronous

Reported by: Bernhard Thiele Owned by:
Priority: high Milestone: 1.9.4
Component: Testing Framework Version:
Keywords: synchronous Cc: Lennart Ochel, Rüdiger Franke, Adrian Pop, Maksimov Doe

Description

Establish a testing procedure for the Modelica_Synchronous library.

In the OSMC Dev meeting 2015-11-16 we discussed to improve the testing procedure. For the beginning following procedure was agreed to be a practical first step:

  • Use the standard comparison mechanism to compare reference result files against simulation result files
  • Create a dedicated repository for storing library result files, so that the (large) binary result files don't increase the size of the git test suite repository

Change History (10)

comment:1 by Bernhard Thiele, 9 years ago

I started setting up a test case for Modelica_Synchronous.Examples.Elementary.IntegerSignals.TimeBasedStep based on result files.

I also checked whether it is possible to compare to Dymola generated result files. They put additional information for clocked variables into the result files, but that information is put within its own "namespace" _Clocks. I guess that Dymola uses that additional information to plot clocked variables different to unclocked variables. However, it should be fine to just compare variable values without taking that additional information into account.

In which directory shall we put the the tests?

Is testsuite/simulation/libraries/3rdParty/Modelica_Synchronous/ appropriate, or is there a better place?

in reply to:  1 comment:2 by Lennart Ochel, 9 years ago

Replying to bthiele:

Is testsuite/simulation/libraries/3rdParty/Modelica_Synchronous/ appropriate, or is there a better place?

I think that is a reasonable location for tests that should be run on each commit. Besides that, there is also the coverage library job that will be run each day. Therefore, we just need an external location for the reference files.

comment:3 by Adrian Pop, 9 years ago

I now created:
https://github.com/OpenModelica/LibraryCoverageReferenceResults
you can create Modelica_Synchronous in there with the results.
I have to check how to give access to the people.

Last edited 9 years ago by Adrian Pop (previous) (diff)

comment:4 by Adrian Pop, 9 years ago

I changed the repo name to: LibraryCoverageReferenceResults to make sure these are reference results, not any other results.

comment:5 by Adrian Pop, 9 years ago

The Developers team can push into this repository directly or via pull requests.

comment:6 by Bernhard Thiele, 9 years ago

I created a first example (https://github.com/OpenModelica/OpenModelica-testsuite/pull/161) for which it would be good to get some feedback in order to improve upon it.

comment:7 by Bernhard Thiele, 9 years ago

Resolution: fixed
Status: newclosed

Created the coverage tests, but integrated them directly into the testsuite https://github.com/OpenModelica/OpenModelica-testsuite (ReferenceFiles/Modelica_Synchronous/* and simulation/libraries/3rdParty/Modelica_Synchronous/*).

Completed the task with the commit https://github.com/OpenModelica/OpenModelica-testsuite/commit/e7d99a181af89df7d789a034a711c87e43ab8666

comment:8 by Dietmar Winkler, 9 years ago

Milestone: Future1.9.4

Sorting these closed tickets away from "Future". Since they were closed after the last 1.9.3 release, it's very likely that they should have been part of the 1.9.4 release.

comment:9 by Martin Sjölund, 9 years ago

Milestone: 1.9.41.9.4-1.9.x

Milestone renamed

comment:10 by Martin Sjölund, 9 years ago

Milestone: 1.9.4-1.9.x1.9.4

Milestone renamed

Note: See TracTickets for help on using tickets.