Opened 9 years ago

Last modified 8 years ago

#3626 accepted defect

Parameter records are not displayed correctly in OMEdit

Reported by: Christian Kral <dr.christian.kral@…> Owned by: Adeel Asghar
Priority: high Milestone: Future
Component: OMEdit Version:
Keywords: Cc: Martin Sjölund

Description

Please consider the attached example of a DC Machine model, which modifies two parameter records:

...brushParameters(V = 0.617), 
frictionParameters(PRef = 0.7162, power_w = 2, wRef = 723.4)...

Make a double click on the DC machine model and chose the Losses tab:

In the brushParameters field only the number 0.617 appears but it is not clear whether this is "V" or "ILinear"

The frictionParameters filed again shows only one value (723.4) but it is not clear to which element of the record the value belongs to.

Attachments (1)

DC_machine.mo (3.3 KB ) - added by Christian Kral <dr.christian.kral@…> 9 years ago.
Example demonstrating parameter record issue

Download all attachments as: .zip

Change History (2)

by Christian Kral <dr.christian.kral@…>, 9 years ago

Attachment: DC_machine.mo added

Example demonstrating parameter record issue

comment:1 by Adeel Asghar, 8 years ago

Cc: Martin Sjölund added
Status: newaccepted

This is fixed now in 520810b/OMEdit.
We need better support for editing parameter record. Right now you have to manually update the values. It would be nice to have a GUI support to open a new dialog with record elements to update them. So I keep this ticket open until we have this support.

Martin, there is a problem with diff API. Follow the following steps,

  • Load the attached model DC_machine.mo.
  • Double click on the DC machine model and choose the Losses tab.
  • Update the brushParameters value from 0.617 to 1.617.
  • Click OK.

Following error message is shown,

[1] 14:37:15 Syntax Error
Missing token: ')'

[2] 14:37:15 Translation Error
[C:/OpenModelica/OMCompiler/Compiler/Script/CevalScriptBackend.mo: 1049:13-1049:124]: Internal error Failed to parse merged string (see generated file SanityCheckFail.mo)

I get the correct model using the list API.

Note: See TracTickets for help on using tickets.