OMEdit doesn't allow to add or change comments

[Francesco Casella]

Load the attached test package in OMEdit.

Select M1 and add a comment above the line Real x = 1;. Save the model. The comment disappears from the screen and is never passed onto the file.

Now select M2, which already has a comment. Edit the comment somehow. Save the model. The applied changes disappear, and are never passed onto the file.

Basically, it is no longer possible to add or edit comments with OMEdit...

[Adam Dershowitz]

FYI, there are a number of tickets that appear to be for this same issue already. It really makes OM unusable, so hopefully will be fixed at some point.
3635
3624 and
3634

For my own use, I have reverted to 1.9.4~dev-621-ga2f446d which still has some oddities with comments and moving text around, but is basically functional (at least I haven't had it just make text disappear completely)

[Adeel Asghar]

Basically its not an OMEdit issue. Infact all the above tickets mentioned by @dersh are related to #3642. Martin recently updated the diff algorithm we were using to make it more faster and that unfortunately broke everything.

[Francesco Casella]

Martin, can you please roll back your commits until this is fixed, and work on a separate fork to fix the bug? A slow implementation is preferable to a broken one!

Thanks

[anonymous]

Done in ee4e7b6 (using the old list()-style unparsing; will change the models but preserve all relevant information). I also have an idea on how to add some sanity checks to the diff algorithm: after you get the merged result, parse both the merged and the after strings, unparse them and compare the strings. If they are not equal, the diff algorithm failed: report an error and just return the after string.

[Francesco Casella]

Problem solved

[Martin Sjölund]

It was not resolved. It was just hacked around.

[Martin Sjölund]

I will consider this fixed once the attached testcase works.

[Martin Sjölund]

Milestone renamed

[Martin Sjölund]

Milestone renamed