#3791 closed defect (fixed)
don't force inlining for annotation(Inline=false)
Reported by: | Vitalij Ruge | Owned by: | Vitalij Ruge |
---|---|---|---|
Priority: | critical | Milestone: | |
Component: | Backend | Version: | |
Keywords: | Cc: | Willi Braun, Rüdiger Franke, Francesco Casella |
Description (last modified by )
Change History (8)
comment:1 by , 9 years ago
Description: | modified (diff) |
---|---|
Milestone: | Future → 1.10.0 |
Priority: | high → critical |
comment:2 by , 9 years ago
follow-ups: 6 7 comment:3 by , 9 years ago
The time for ModelicaTest_trunk went down from 1931s yesterday to 1747s today. Great!
https://test.openmodelica.org/libraries/ModelicaTest_trunk/BuildModelRecursive.html
comment:4 by , 9 years ago
@vruge What do you mean by implicit inlining and to what kind of functions does it apply?
comment:5 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:6 by , 9 years ago
Replying to rfranke:
The time for ModelicaTest_trunk went down from 1931s yesterday to 1747s today.
I guess it fixes partial the jump 1800 to 1950 from solveSimpleEqnForSim.
imprecise approximate(without solveSimpleEqnForSim) it is 1782s to 1747s.
Great!
Thanks :)
comment:7 by , 9 years ago
Replying to rfranke:
The time for ModelicaTest_trunk went down from 1931s yesterday to 1747s today. Great!
https://test.openmodelica.org/libraries/ModelicaTest_trunk/BuildModelRecursive.html
Better still, the time to build ModelicaTest.Fluid.Dissipation.TestCases.PressureLoss.Orifice
went down from 264 s to 8.7 s (!). Also the simulation time has slightly improved, further confirming that library developer's advice should preferably be trusted :)
fixed with PR568
and improved with PR582
from local testing -> we will get some impact for e.g.
let's see the next result from coverage :)