Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#3791 closed defect (fixed)

don't force inlining for annotation(Inline=false)

Reported by: Vitalij Ruge Owned by: Vitalij Ruge
Priority: critical Milestone:
Component: Backend Version:
Keywords: Cc: Willi Braun, Rüdiger Franke, Francesco Casella

Description (last modified by Francesco Casella)

see comments
#3785/9, #3785/11

we shouldn't force inline function with annotation(Inline=false)

possible steps:

1) added InlineType default
2) replace DAE.NO_INLINE() in e.g. Inline.forceInlineExp(inExp,(functions,{DAE.NORM_INLINE(),DAE.NO_INLINE()})
whit DAE.DEFAULT_INLINE()

Change History (8)

comment:1 by Francesco Casella, 9 years ago

Description: modified (diff)
Milestone: Future1.10.0
Priority: highcritical

comment:2 by Vitalij Ruge, 9 years ago

fixed with PR568
and improved with PR582

from local testing -> we will get some impact for e.g.

ModelicaTest.Fluid.Dissipation.TestCases.PressureLoss.SeveralTestCases

let's see the next result from coverage :)

comment:3 by Rüdiger Franke, 9 years ago

The time for ModelicaTest_trunk went down from 1931s yesterday to 1747s today. Great!

https://test.openmodelica.org/libraries/ModelicaTest_trunk/BuildModelRecursive.html

comment:4 by Lennart Ochel, 9 years ago

@vruge What do you mean by implicit inlining and to what kind of functions does it apply?

comment:5 by Vitalij Ruge, 9 years ago

Resolution: fixed
Status: newclosed

in reply to:  3 comment:6 by Vitalij Ruge, 9 years ago

Replying to rfranke:

The time for ModelicaTest_trunk went down from 1931s yesterday to 1747s today.

I guess it fixes partial the jump 1800 to 1950 from solveSimpleEqnForSim.

imprecise approximate(without solveSimpleEqnForSim) it is 1782s to 1747s.

Great!

Thanks :)

Last edited 9 years ago by Vitalij Ruge (previous) (diff)

in reply to:  3 comment:7 by Francesco Casella, 9 years ago

Replying to rfranke:

The time for ModelicaTest_trunk went down from 1931s yesterday to 1747s today. Great!

https://test.openmodelica.org/libraries/ModelicaTest_trunk/BuildModelRecursive.html

Better still, the time to build ModelicaTest.Fluid.Dissipation.TestCases.PressureLoss.Orifice went down from 264 s to 8.7 s (!). Also the simulation time has slightly improved, further confirming that library developer's advice should preferably be trusted :)

comment:8 by Martin Sjölund, 7 years ago

Milestone: 1.10.0

Milestone deleted

Note: See TracTickets for help on using tickets.