dasslJacobian flag is rename to jacobian

[Christoph <buchner@…>]

I just downloaded the current Windows 64bit nightly, and when simulating examples, e.g. Modelica.Fluid.Examples.HeatingSystem, I get in the output tab:

stdout | OMEditInfo | C:/Users/buchner/AppData/Local/Temp/OpenModelica/OMEdit/Modelica.Fluid.Examples.HeatingSystem.exe -port=50112 -logFormat=xml -override=startTime=0,stopTime=6000,stepSize=12,tolerance=0.0001,solver=dassl,outputFormat=mat,variableFilter=.* -r=Modelica.Fluid.Examples.HeatingSystem_res.mat -dasslJacobian=coloredNumerical -w -lv=LOG_STATS

stdout | warning | invalid command line option: -dasslJacobian=coloredNumerical

changing the dass jacobian setting in simulation setup has no effect on this.

This is on OMEdit v1.10.0-dev-62-gc84ef06 connected to OpenModelica v1.10.0-dev-237-g583180a, 64bit on Windows 10. I uninstalled the previously installed 1.9.4 32bit before.

[Christoph <buchner@…>]

This does not occur with OMEdit v1.10.0-dev-53-g45d32fb, Connected to OpenModelica v1.10.0-dev-196-g8bddad5, which I just installed instead.

[adrpo]

Hm. We only changed the compiler to gcc 5.3.0 from gcc 4.4.0, nothing more in the builds.
I will check if we still support the flag as there were some changes to the C runtime recently, maybe they are to blame.
@wbraun any comments on this?

[adrpo]

Hi, it seems that 96898a5de5961eae09f5cfd178ff99d40cc915d0/OMCompiler removed that flag by generalization. @wbraun maybe we should have deprecated the flag for a while by changing it internally to the new ones.

[wbraun]

Yes, I renamed the flag, since I want to use it also for other solvers then dassl.
It is now called just "-jacobian".
@adrpo Do you think we should add the other flag name and mark it as deprecated?

[adrpo]

Maybe would be good to have a small piece of code that checks for the old flag, give a warning and use the new one. At least until people update their scripts.

I even wonder if we don't actually have this flag set by OMEdit as Christoph seems to have used the default flags.

@adeas31 do we give this flag in OMEdit by default?

[wbraun]

Ah, it is OMEdit that use also dasslJacobian. I forgot about that. So actually we just need to adjust that in OMEdit.
@adeas31 Could you do that?

[Christoph <buchner@…>]

@adrpo yes, I have used default flags

[adeas31]

Updated the flag used in OMEdit in 2d4e99c/OMEdit.

[sjoelund.se]

Milestone deleted