Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#3872 closed defect (fixed)

Reduced coverage of Modelica_Synchronous_cpp

Reported by: Rüdiger Franke Owned by: Niklas Worschech
Priority: blocker Milestone:
Component: Cpp Run-time Version:
Keywords: Cc: Volker Waurich

Description

Tonight many models failed to validate that were working until yesterday.

See:
https://test.openmodelica.org/libraries/trend-detailed.html

Verify: 29 (yesterday 57)
Compile: 80 (yesterday 81)

It is very hard to understand 4f37b928/OMCompiler. It changed 70 files with 2,877 additions and 2,070 deletions at once and without reasonable commit message.

Please correct your commit!

Change History (6)

comment:1 by Lennart Ochel, 9 years ago

Yes, that looks like a bad merge commit. I can just advise to use pull requests, so that we can have a look before stuff is actually merged.

comment:2 by Lennart Ochel, 9 years ago

Owner: changed from niklas to Niklas Worschech
Status: newassigned

comment:3 by Martin Sjölund, 9 years ago

This is why you should always open a pull request so you can review your actual changes compared to the current master, and always rebase against origin/master before creating a PR.

comment:4 by Adrian Pop, 9 years ago

Can we close this now? The coverage is back to normal.

comment:5 by Niklas Worschech, 9 years ago

Resolution: fixed
Status: assignedclosed

comment:6 by Martin Sjölund, 7 years ago

Milestone: 1.10.0

Milestone deleted

Note: See TracTickets for help on using tickets.