simulate(..) returns record instead of string

[Bernhard Thiele]

According the its signature the MOS scripting function simulate(..) should return a String. However, (?sometimes?) a record is returned.

Consider following MOS script:

loadModel(Modelica);

res := simulate(Modelica.Blocks.Examples.PID_Controller);
print("A");
print(res); // No error, but this line will be blank?
print("B");

if true then
  res := simulate(Modelica.Blocks.Examples.PID_Controller);
  print(res); // Throws an error that a record is passed, but a String is expected
else
  print("Just to have an else");
end if;

The first print doesn't work (but throws no error), the second print fails with a type error (expected String, but got a record).

How is the return value of simulate(..) supposed to work?

[Bernhard Thiele]

The mos script calling simulate(..)

[anonymous]

It is supposed to be a record that is passed. If the ModelicaBuiltin.mo says otherwise, that is an error.

[Bernhard Thiele]

OK. I just finished a commit that would change the return value to a String (​https://github.com/OpenModelica/OMCompiler/pull/953).

However, I'm also fine with a record, which would mean that the signature should be fixed.

Some of the record fields are created dynamically in CevalScriptBackend.createSimulationResult(..). If one was to fix the signature, I suppose one will need a static record type for the return value?

[Martin Sjölund]

I think the full record should always be created, but when doing ValuesUtil.valString to show the value in the mos-script it should filter out the fields that are not testsuite-friendly.