Incorrect evaluation of boolean vector expression in when statements

[Francesco Casella]

Consider the following test case:

model M
  Boolean b1, b2;
  Integer i(start = 0, fixed = true);
equation
  b1 = if time > 0.1 then false else false;
  b2 = if time > 0.2 then true else false;
  when cat(1,not{b1}, not {b2}) then
    i = pre(i)+1;
  end when;
end M;

When compiling it, I get

M.c:125:69: error: incompatible types when assigning to type 'modelica_boolean {aka signed char}' from type 'boolean_array {aka struct base_array_s}'
   data->localData[0]->booleanVars[0] /* $whenCondition1 DISCRETE */ = tmp4;

Note that other boolean expressions are dealt with niceley, e.g.

model M2
  Boolean b1, b2;
  Integer i(start = 0, fixed = true);
equation
  b1 = if time > 0.1 then false else false;
  b2 = if time > 0.2 then true else false;
  when cat(1,{not b1}, {not b2}) then
    i = pre(i)+1;
  end when;
end M2;

[Martin Sjölund]

Ticket retargeted after milestone closed

[Martin Sjölund]

Milestone moved to 1.12.0 due to 1.11.0 already being released.

[Francesco Casella]

With the new front-end, OMEdit just crashes on this test case

[Per Östlund]

Replying to casella:

With the new front-end, OMEdit just crashes on this test case

That was actually fixed by sjoelund.se yesterday in 76aa0b33, now it instead fails because of missing support for cat. But at least it doesn't segfault anymore.

[Francesco Casella]

The model M now simulates correctly with OMEdit v1.13.0-dev-113-g8c6364e6 (64-bit) connected to v1.13.0-dev-602-g4204ff08e (64-bit), when using the new FE.

Also this variant simulates correctly

model M3
  Boolean b1, b2;
  Integer i(start = 0, fixed = true);
equation
  b1 = if time > 0.1 then false else true;
  b2 = if time > 0.2 then false else true;
  when cat(1,not{b1}, not {b2}) then
    i = pre(i)+1;
  end when;
end M3;