Opened 8 years ago
Closed 8 years ago
#4072 closed defect (fixed)
Wrong array storage order in Cpp FMU2
| Reported by: | Rüdiger Franke | Owned by: | Rüdiger Franke |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.11.0 |
| Component: | Code Generation | Version: | |
| Keywords: | Cc: |
Description
Multi-dimensional arrays are transposed in modelDescription.xml. The bug was introduced after the release of 1.9.4. It originates from the function SimCodeUtil.getValueReference.
5e6d738f1b/OMCompiler introduced the function to avoid an index mapping at runtime (rfranke)
2663366d42/OMCompiler introduced a call argument for storage order (mwalther)
6c675e6ea5/OMCompiler transposed the storage order (and introduced the bug??) (vwaurich)
63a287984c/OMCompiler rewrote the function (hopefully not breaking negated aliases for the Cpp runtime?) (sjoelund)
Change History (6)
comment:1 by , 8 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 8 years ago
Pull requests 1133 (OMCompiler) and 421 (testsuite) further correct alias handling.
@sjoelund: your commit broke negative aliases indeed, confirmed with "Expected output" in the testsuite!?
comment:3 by , 8 years ago
If this fixes the issue, you should port it to maintenance/v1.10 as well.
comment:5 by , 8 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → accepted |
comment:6 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
The bug fix was ported to 1.9.7.
4f6ee12c77bccd/OMCompiler fixes the storage order for FMI export.
7886e2e7a9c534/OpenModelica-testsuite adds two tests for simulation and FMI export.
@vwaurich: can you please check and possibly add a test motivating your earlier commit?