OMEdit Visual glitches on high-res monitors

[massimo ceraolo]

Today's 4k monitors in practice require fonts to be scaled-up. factors between 1.5x - 2.0x on DPI are typical.
Generally OMEdit behaves well in such environments, however:
1) the plus sign near variables in the Variables Browser is too large (First.png)
2) OMEdit about window is too small in comparison with font sizes (Second.png)
3) tools on the main toolbox are correctly scaled-up, while icons of views (icon, diagram, text, documentation) are too small (Third.png).
4) the documentation browser shows a very small font (looks like not being scaled-up, as if its size is set in pixels instead of points)

The screenshots I add refers to 1.75x (i.e. 168 virtual DPI) in windows.

[Adeel Asghar]

3) tools on the main toolbox are correctly scaled-up, while icons of views (icon, diagram, text, documentation) are too small (First.png).

I think you are referring to a wrong image. I can't find any icons of view in First.png.

[massimo ceraolo]

I think you are referring to a wrong image. I can't find any icons of view in First.png.

Right. I forgot to switch to modelling perspective.
To update it I need my work's PC: I'll do this tomorrow...
DONE (Third.png)

[massimo ceraolo]

Today I made a further check, with the same OMEdit version (1.11.0-dev267), but without zooming fonts.
I had an additional small issue: the package branch markers were first nice ">" symbols (Fourth.png). but, as far as I opened a branch, they were converted into squares, containing the "+" sign, with a too large size (Fifth.png).

[Henning Kiel]

This is basically a duplicate of https://trac.openmodelica.org/OpenModelica/ticket/3414

[Martin Sjölund]

Most of these issues seem Windows-specific. The about box is rendered in a sort of weird way on Linux too though. (Note: Need Ubuntu 16.10+ for Hi-DPI in Qt applications)

Does the documentation browser show a small font by default on Windows as well? (I usually do ctrl+mousewheel up for Linux in that Window).

[massimo ceraolo]

Most of these issues seem Windows-specific.

Indeed if the fonts' and windows' sizes are defined in pixels, these issues should be cross-platform.
I've some experience in making DPI-aware software with Qt, and I found it easy to make DPI-aware programs using simple rules:

• defining fonts in points instead of pixels (or, in case a special effect is wanted as a fraction of window's actual size )
• resizing windows on proportion to actual DPI's (and, for which maximum and minimum sizes are defined resizing them as well)
• adjusting the maximum size of those toolButtons for which maximum and minimum sizes are defined in proportion to actual DPI's

(not to mention the need to always use layouts, that is standard Qt GUI programming).

If none of this is done, I expect on other OS's problems similar to those we see in Windows.

BTW, what I did does not make usage e of any recent feature of Qt. I retrieved DPI's using

QScreen *screen=QGuiApplication::primaryScreen();
int myDPI=screen->logicalDotsPerInch();

Does the documentation browser show a small font by default on Windows as well? (I usually do ctrl+mousewheel up for Linux in that Window).

Yes, it is small, It looks like its size is defined in OMEdit software in pixels (that does not scale when DPI's are changed) and not in points.

Final consideration. There's a lot of software around that is not DPI-aware yet. The very box in which I'm writing now contains fonts that appear very tiny on my 4k screen!

[Adeel Asghar]

cdab4c8/OMEdit fixes point 3.

[Adeel Asghar]

Point 2. The about window uses a png as background which is ofcourse fixed size and doesn't scale up. I think we should get rid of it and just show the information in a standard window.

[Adeel Asghar]

c9f07ae/OMEdit adds a new about dialog which should fix point 2.

[Henning Kiel]

The two buttons "Create New Modelica Class" and "Open Model/Library File(s)" are too small in height on my hi-res screen, see: https://trac.openmodelica.org/OpenModelica/attachment/ticket/3414/omedit_win81_largefonts.png
This is also the case with 1.11 beta1

[massimo ceraolo]

Replying to hkiel:

The two buttons "Create New Modelica Class" and "Open Model/Library File(s)" are too small in height on my hi-res screen, see: https://trac.openmodelica.org/OpenModelica/attachment/ticket/3414/omedit_win81_largefonts.png
This is also the case with 1.11 beta1

Your buttons have the same size as mine in "Third.png".
They are largher than buttons to change views (icon, diagram, text, documentation), which I asked to enlarge.

To enlarge "Create New Modelica Class" and the other buttons in the main toolbar is a question of taste: e.g. I'm at ease with the current size. On the opposite, the buttons to change views were really very small.

BTW, Dymola as well is not very DPI-aware: its buttons appear all tiny, much smaller than our "Create New Modelica Class" and the other buttons of ours in the main toolbar.

[Adeel Asghar]

@ceraolo you misunderstood. @hkiel meant the two buttons shown in the bottom of the welcome window.

[massimo ceraolo]

ah, yes!
:-(

[Adeel Asghar]

6e46b93/OMEdit fixes the issue @hkiel mentioned about "Create New Modelica Class" and "Open Model/Library File(s)" buttons.

30ec275/OMEdit fixes point 4.

Point 1 is a qt bug (​https://bugreports.qt.io/browse/QTBUG-52689). It will be fixed once we move from Qt 5.6 to Qt 5.7. Unfortunately, the plan for 1.11 release is to use Qt 5.6.

I guess everything you mentioned is fixed. If there is nothing else you can close the ticket.

[massimo ceraolo]

The link says that the Qt bug is fixed in 5.6.1. If this is confirmed for our issue, maybe it is possible to use that version for the OM 1.11 release? In principle, in case semaver is valid for Qt, this should not create any problem.

[Adeel Asghar]

Unfortunately we can't do that. We use msys2 for development and in order to get new qt version we need to upgrade msys2 which means it will also upgrade from gcc 5.x to gcc 6.x. Updating gcc version just before the release is too risky.

However, we can do it for 1.12.

[massimo ceraolo]

I see. Could not not envisage this.
I'm going to close this ticket.
We will wait for 1.12.

[massimo ceraolo]

The documentation browser text is very tiny on hi-res moniteors.
When "info" button is clicked, however it has normal size.

[Adeel Asghar]

When info button is clicked you see an editor instead of documentation browser.
Can you provide a screenshot?

[massimo ceraolo]

In enclose "docu.png" (tiny fonts) and "info.png" (correct fonts).

[Adeel Asghar]

They seems right to me.
Its two different views with two different fonts. docu.png is your system default font with default font size (i.e., on Windows "MS Shell Dlg 2" with size 12), info.png font is set via Tools->Options->Text Editor.

Note that QWebView (i.e, docu.png) doesn't scale the font based on your DPI instead it uses a fixed 96 DPI. So OMEdit uses the zoom factor to make the font readable which means depending on our screen different zoom level is used. In the source code it looks like this,

QWidget *pScreenWidget = QApplication::desktop()->screen();
setZoomFactor(pScreenWidget->logicalDpiX() / 96);

[massimo ceraolo]

Do you use the same size for the libraries tree and for info browser?
If so, something should be wrong: see comparison of the two fonts under a 175% scaling factor (comparison.png).

[Adeel Asghar]

No, they are two different fonts.
I checked it a bit more and find out that Qt is using Segoe UI with size 9 for Libraries browser. However, for info browser I use the system default font i.e., MS Shell Dlg 2 with size 8.

[massimo ceraolo]

I repeated my tests on 1.12.0-dev40-222: now that we have a size spinbox I can play with it.

I've seen strange things: with a 150% magnification on my screen an approximate equality between Libraries Browser and Documentation Browser fonts is when I set the documentation font size to "5"; with a 200% magnification factor this happens using your default font size "3".

So it seems to be a problem related to my system, as you guessed. I think I can close this ticket now.

BTW, which unit is the font size you chose in the Info Editor? "3" cannot mean three points: it is much larger than that. So, what does it mean?