Opened 8 years ago

Closed 8 years ago

#4169 closed defect (wontfix)

Inappropriate use of red colour in OMEdit Compilation window

Reported by: Francesco Casella Owned by: Adeel Asghar
Priority: high Milestone: 1.12.0
Component: OMEdit Version:
Keywords: Cc:

Description

Currently, both errors and warnings are coloured in red in the Compilation tab of OMEdit Simulation Output windows. IMHO this is not a good idea. Red should be reserved to errors, i.e., problems that prevent the code to be successfully compiled. Warning should use a different colour, e.g., orange.

If I have one error and 100 warnings in the log, the colour code should help to immediately identify the error.

BTW, if I compile Modelica.Blocks.Examples.Filter with the most recent nightly I installed, I get 7 different warning of type "warning: excess elements in struct initializer", all showing up in glowing red. This does not convey a message of reliablity and sound design to a casual user. In fact, I always get scared that something went badly wrong with the latest nightly, and then a bit confused, though relieved, by the final blue message "Compilation process finished successfully", which seems to contradict the red stuff that previously flew by in the window.

Change History (2)

comment:1 by Adeel Asghar, 8 years ago

Compilation output is coming directly from the compiler i.e., gcc. Bydefault gcc writes warnings and errors on stderr and other messages on stdout. OMEdit gives black color to stdout and red color to stderr. We could parse this information and can distinguish between an error and a warning but data from streams can come in chunks so there is no guarantee that the string comparison will always work there.

As for simulation output other people think otherwise. See ticket:4048#comment:14

in reply to:  1 comment:2 by Francesco Casella, 8 years ago

Resolution: wontfix
Status: newclosed

Replying to adeas31:

Compilation output is coming directly from the compiler i.e., gcc. Bydefault gcc writes warnings and errors on stderr and other messages on stdout. OMEdit gives black color to stdout and red color to stderr.

OK.

We could parse this information and can distinguish between an error and a warning but data from streams can come in chunks so there is no guarantee that the string comparison will always work there.

That would probably be overkill.

As for simulation output other people think otherwise. See ticket:4048#comment:14

De gustibus non est disputandum. Besides, it seems I'm outvoted already on this topic :)

I don't want to start an argument about colours (we have more serious problems to worry about), so I'm closing this ticket right away.
Yet, I don't think that having stuff in red showing up in the compilation windows of a release candidate on plain vanilla models such as Modelica.Blocks.Examples.Filter is good for the sake of OMC's reputation, so I just opened #4170 for that.

Note: See TracTickets for help on using tickets.