Consecutive end <class> statements on the same lines wreak havoc in OMEdit

[Francesco Casella]

Through a sequence of operations that unfortunatly I cannot reproduce, I ended up with a .mo file with this content:

package P
 package Q
    model M1
    end M1;

    model M2
    end M2; end Q;
end P;

i.e., the newline after end M2 got lost. This should also be fixed, but unfortunatly I have no idea how to reproduce this part.

AFAIK, this is perfectly legal Modelica code, but OMEdit cannot handle it: if I select model P.Q.M2, I see

    model M2
    end M2; end Q;

and whatever modification I apply, I get a syntax error.

[Adeel Asghar]

I made OMEdit handle such code 4bf74df/OMEdit.

I guess diffModelicaFileListings somehow removed the newline. @Martin do you have any idea?

[Martin Sjölund]

As far as I remember, this happens when you start with something like:

package P
  package Q
    model M1
    end M1;
  end Q;
end P;

And then add a model M2 (or a component). The diff will not insert extra line endings, which means you end up with the model in the ticket.

[Adeel Asghar]

Replying to sjoelund.se:

As far as I remember, this happens when you start with something like:

package P
  package Q
    model M1
    end M1;
  end Q;
end P;

And then add a model M2 (or a component). The diff will not insert extra line endings, which means you end up with the model in the ticket.

So do we need to fix this?
OMEdit can already handle if there is no extra line ending.

[Francesco Casella]

Please do, if possible for 1.11 already. I guess that's how we ended up in the situation reported here.

[Francesco Casella]

Probably the package in question was initially built with a text editor, which is legitimate, and lacked the trailing newline, which is also perfectly legitimate.

[Francesco Casella]

Seems to be fixed now, as I could no longer reproduce the error.