Opened 8 years ago
Closed 7 years ago
#4305 closed enhancement (fixed)
OMEdit: Message "Revert to last correct version" - default behavior
Reported by: | Jan Kokert | Owned by: | Adeel Asghar |
---|---|---|---|
Priority: | normal | Milestone: | 1.12.0 |
Component: | OMEdit | Version: | |
Keywords: | Revert to last correct version behavior | Cc: |
Description
If a model with incorrect syntax is saved, a message pops up to either Fix error(s) manually(1) or Revert to last correct version(2). If in a hurry, one hits the escape key or closes the message window, option (2) is carried out, although button(1) is highlighted.
After realizing that one took the wrong choice, one will realize that the source code is lost (e.g. it can NOT be restored using UNDO). This would be particularly bothersome for OMEdit beginners.
So basically we have three issues:
Issue 1 (enhancement): The default behavior of the escape key or of closing the window should follow the behavior indicated by the button highlighting and thus continue with "Fix error(s) manually".
Issue 2 (defect): "Revert to last correct version" should be UNDO-able.
Issue 3 (enhancement): Is it possible to add a checkbox, that this message will not pop up again? As an indicator that the syntax is correct or not, a little text could be added to the very bottom status bar next to (or instead of) "X: ~ | Y: ~".
Change History (6)
comment:1 by , 8 years ago
Milestone: | Future → 1.12.0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:2 by , 8 years ago
Great, that issue 1 is fixed. This was my main concern. I did not know about that ticket. Still, I think adding a checkbox with ("Don't annoy me again") will not undermine the idea of that ticket as everybody can decide by its own how important that message is. But this is just a suggestion.
Have you noticed that the message pops up continuously when you switch between models in the library browser? Then this message will become really nasty and will blink like a firework!
comment:3 by , 8 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Well I can add a checkbox and let OMEdit remember user's decision. Then instead of showing the message box we can use user's last preference.
Of course it will pop up when you switch between models without fixing the issue since switching between models trigger the syntax check.
comment:4 by , 8 years ago
Yes, a checkbox will be great! And yes, it is ok that the message will pop up when you select a different library item. But it will pop up again even if you clicked on "Fix error(s) manually(1)".
Assume you are a beginner and in middle of programming something and you look for a working code snippet. Then this message will we very distracting (as you know that you right into something, which is syntactically not correct...)
I point out these little issues as (hopefully) the OMEdit community will grow - and we don't want to annoy them right at the beginning ;-)
comment:5 by , 8 years ago
Only
add a checkbox and let OMEdit remember user's decision.
is missing to close that ticket :)
Issue 1 is fixed in feadabe/OMEdit.
Issue 2: We can't do this since we don't have any defined state for it.
Issue 3: Not really. Sometime ago in some ticket (I don't remember the ticket number) it was requested to make this dialog like this so it always show up because it is very important. So if I do what you want then we are just moving back and forth.