Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4315 closed enhancement (worksforme)

Request to add PhotoVoltaics library as systems library to OpenModelica

Reported by: Christian Kral <dr.christian.kral@…> Owned by: Martin Sjölund
Priority: high Milestone: 1.12.0
Component: Installation program Version:
Keywords: Cc:

Description

In a recent project I developed the PhotoVoltaics libarary together with a group of students. The library is hosted on https://github.com/christiankral/PhotoVoltaics

One main goal of this library was, that most examples work with OpenModelica. Thanks to your support in #4222, finally all example models work in OpenModelica.

We are about to release version 1.0.0 soon. The library components are tested and validated by measuring data in the package PhotoVoltaics_TGM. On my opinion it were mutually beneficial to have the PhotoVoltaics pacakge and the PhotoVoltaics_TGM package included in OpenModelica.

Change History (8)

comment:1 by Adeel Asghar, 8 years ago

Component: OMEditInstallation program
Milestone: Future1.12.0
Owner: changed from Adeel Asghar to Martin Sjölund
Status: newassigned

comment:2 by Martin Sjölund, 8 years ago

Resolution: worksforme
Status: assignedclosed

They already are part of OM: https://github.com/OpenModelica/OMLibraries/commit/7ef0f48c4e5f8fcf4321fbc8f75091649e2aabec (apt install omlib-photovoltaics-tgm pulls in PhotoVoltaics and Buildings).

If they are missing in other distributions (Windows for example), add a note and Adeel can update the script.

comment:3 by Martin Sjölund, 8 years ago

comment:4 by Christian Kral <dr.christian.kral@…>, 8 years ago

Thanks for the link and for including the library.

As I understand, you are including the actual master version of the PhotoVoltaics (and other libraries on GitHub)? I regularly create new versions (tags on GitHub), because I try to make simulation applications as reproducible as possible. I have thus one more question: Is it possible that you use the latest release version (tag) instead of the master version? Or shall I provide a default branch different to master (something like "the latest release" branch as default branch)?

comment:5 by Martin Sjölund, 8 years ago

I can change our repository to follow a release branch instead of the master if you prefer

comment:6 by Christian Kral <dr.christian.kral@…>, 8 years ago

I created the branches "release" for these GitHub repositories:

  • PhotoVoltaics
  • KeyWordIO
  • WindPowerPlants

Please follow the release branches when including library versions in OpenModelica. Thanks a lot in advance.

May also ask you to include the library ElectroMechanicalDrives which I recently added to GitHub. The actual version v0.12.0 is also placed in a "release" branch (https://github.com/christiankral/ElectroMechanicalDrives/tree/release). The ElectroMechanicalDrives package is intended to model and simulate electric vehicles (cars, trains) including a simplified drive cycle, power train, power electronics, battery. I know that I have to improve the documentation, but its already quite stable and most examples are simulating in OpenModelica. I am using this library a lot in teaching at my college of engineering, where I exclusively use OpenModelica.

comment:7 by Martin Sjölund, 8 years ago

Done

comment:8 by Christian Kral <dr.christian.kral@…>, 8 years ago

Thanks a lot.

Note: See TracTickets for help on using tickets.