Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4319 closed defect (fixed)

OMEdit: Incomplete display of Icons with connector annotations

Reported by: Jan Kokert Owned by: Adeel Asghar
Priority: normal Milestone: 1.12.0
Component: OMEdit Version:
Keywords: Incomplete icon display annotations Cc:

Description

The model icon in the library view is not loaded completely if it contains annotations of connectors. Consider the following model:

model test
  extends Modelica.Electrical.Analog.Interfaces.OnePort;
  extends Modelica.Icons.Package;
  extends Modelica.Icons.SignalBus;
end test;

After loading the file, the icon is displayed without the connectors p and n. Now comment any of the lines 2..4, save the file, uncomment and save again. Now the icon will be displayed completely. I added two icons from the MSL in the example to show the difference between 'normal' icon extend and annotations extend.

Change History (2)

comment:1 by Adeel Asghar, 8 years ago

Milestone: Future1.12.0
Resolution: fixed
Status: newclosed

We have disabled loading the connectors when the class is loaded in the Libraries Browser. So that users get fast browsing of libraries. Basically we defer the loading and only load when really needed. That is why you don't see it when you load the class but as soon as you change something the icon is updated.

However, I think I forgot to add the code to update the icon when connectors are really loaded. I have now added the code in fbe98a6/OMEdit. So now if you load the file you will see the icon in the Libraries Browser without connectors since they are not loaded yet but when you double click to open the class the icon is updated since connectors are loaded.

comment:2 by Jan Kokert, 8 years ago

I understand now that loading of all connectors is deferred due to a gain in performance. However, if you don't know that - it looks like a bug not a feature. I think the best way of solving this is to add an option to the settings:
"[x] Defer loading connectors when opening a library"
What do you think? I know it is again more work, but it will contribute to a solid appearance of OMEdit.

Note: See TracTickets for help on using tickets.