Opened 8 years ago
Last modified 8 years ago
#4344 accepted defect
OMEdit: keep UNDO stack after text view changes
| Reported by: | Jan Kokert | Owned by: | Adeel Asghar |
|---|---|---|---|
| Priority: | normal | Milestone: | Future |
| Component: | OMEdit | Version: | |
| Keywords: | undo in TextView and DiagramView | Cc: |
Description
Even if it seems to be a more time-consuming task, I recommend merging the UNDO stack of the Text View with the stack of the Diagram View as discussed in #4334#comment:13.
It is just a strange behavior that you must go the to correct view to undo things. People how use OMEdit assume that the content in Text View and Diagram View is a different representation of the SAME thing and expect a coherent behavior especially for undo/redo.
Change History (1)
comment:1 by , 8 years ago
| Status: | new → accepted |
|---|---|
| Summary: | OMEdit: merge UNDO stack of Text View and Diagram View → OMEdit: keep UNDO stack after text view changes |
Note:
See TracTickets
for help on using tickets.
It is not possible to merge the two stacks since the one in QPlainTextEdit is internal and I can't access it. However, I made them work together as one. So you change things when you are in diagram view and still you can undo them when you are in text view.
However, when you explicitly change something in the text view and switch back to Diagram/Icon view then we clear the stack since we don't know what is changed and we redraw the whole icon & diagram view.
This is a limitation with the current design we have. This could be fixed if we instead of redrawing everything just apply the changes that are done (but that's not easy :D).
So I am updating this ticket from merge undo stack to keep undo stack.