Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4345 closed defect (wontfix)

OMEdit: correct size for pages in options dialog

Reported by: Jan Kokert Owned by: Adeel Asghar
Priority: low Milestone: 1.12.0
Component: OMEdit Version:
Keywords: option pages size Cc:

Description

When we open Tools->Options there are many pages, where the scrollable area on the right is larger than the actual content. If you quickly flicker through the pages using the tree on the left, you might overlook some options. At least due to the fact, that the right vertical scroll bar is not reset to the top position when going through the options.

It seems that all pages have the same height which might be simpler to implement. But I think this just doesn't look right and the pages shall have a size which is adjusted to the content.

Change History (6)

comment:1 by Adeel Asghar, 8 years ago

Resolution: wontfix
Status: newclosed

The different pages have different heights so the best height for the dialog is max(all pages height) but this is not good for some low resolution monitors (https://github.com/OpenModelica/OMEdit/commit/8b1c62bff9b85cee6d6c6196e85b6d213fb0852a).

I could reset the scroll bar to top position when page is changed.

It seems like this is not the first time you have asked for it. See #4017.

comment:2 by Jan Kokert, 8 years ago

I could reset the scroll bar to top position when page is changed.

Yes, please!

Well, in #4017 the options dialog is also the matter of concern, but the issue is a bit different. True, I could have reopened the old ticket, but actually, I forgot the old one :D

Is "small resolution" really an issue today with 4k displays? I thought "high resolution" will cause more trouble actually...

comment:3 by Adeel Asghar, 8 years ago

I could reset the scroll bar to top position when page is changed.

Yes, please!

Done in 7007a3f/OMEdit.

Is "small resolution" really an issue today with 4k displays? I thought "high resolution" will cause more trouble actually...

Yes, because bigger dialog on small resolution screen is unusable since you can't resize it. The way scrollbars are implemented makes it useful for both low and high resolution. If you have 4k display then you can just resize the dialog to a width/height where no scrollbars are visible and OMEdit will remember the size :)

comment:4 by Jan Kokert, 8 years ago

Unfortunately, I do not have a 4K display yet. Actually, I just wanted to point out, that it is good to keep OMEdit also usable at tiny resolutions, even if they are less and less prominent.
Thanks for the fix - this will help!

Sorry to ask again, but what is the reason for:

so the best height for the dialog is max(all pages height)

Can't have every page its own height, dependent on the content?

Version 0, edited 8 years ago by Jan Kokert (next)

in reply to:  4 comment:5 by Adeel Asghar, 8 years ago

Replying to janK:

Unfortunately, I do not have a 4K display yet. Actually, I just wanted to point out, that it is good to keep OMEdit also usable at tiny resolutions, even if they are less and less prominent.
Thanks for the fix - this will help!

Sorry to ask again, but what is the reason for:

The different pages have different heights so the best height for the dialog is max(all pages height)

Can't have every page its own height, dependent on the content? I'm not talking about the height of the whole dialog, just the height of the individual pages on the right.

Yes every page can have its own height but how do you adjust the page with maximum height? For that we need to have a dialog which can accommodate that height and that's when things get ugly for low resolutions.

comment:6 by Adeel Asghar, 7 years ago

Milestone: Future1.12.0
Note: See TracTickets for help on using tickets.