Opened 7 years ago

Closed 4 years ago

#4469 closed defect (fixed)

OMEdit does not update diagrams of derived classes

Reported by: massimo ceraolo Owned by: Adeel Asghar
Priority: high Milestone: 1.18.0
Component: OMEdit Version:
Keywords: Cc:

Description (last modified by massimo ceraolo)

If I rename a partial class submodel, the inheriting class does not show the submodel as renamed, but works.
Using the attached TestRename:
1) rename in PartialIce from the diagram view toPowW into toPowW0; save file
2) look at IceT (that uses PartialIce): toPowW is not renamed.
3) run TestIceT (that uses IceT) => it works!

I'm not totally sure, but in addition to not updating the model name in inherited models, something more serious is done by OMEdit in such cases. This morning, when doing something similar, I ended up with a corrupted package. But I can not replicate this.

Attachments (1)

TestRename.mo (15.0 KB ) - added by massimo ceraolo 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by massimo ceraolo, 7 years ago

Description: modified (diff)

comment:2 by Adeel Asghar, 7 years ago

Milestone: 1.12.01.13.0

by massimo ceraolo, 7 years ago

Attachment: TestRename.mo added

comment:3 by massimo ceraolo, 7 years ago

I checked with 1.12 beta2 and the issue is still there.

BTW, It seems that I forgot to add the test case, that I enclose now.

For me it is a bug, and should be fixed before 1.12 official release. Maybe this is rather simple and was not addressed earlier because the lack of the supporting file.

comment:4 by Francesco Casella, 6 years ago

Milestone: 1.13.01.14.0

Rescheduled to 1.14.0 after 1.13.0 releasee

comment:5 by Francesco Casella, 5 years ago

Milestone: 1.14.01.16.0

Releasing 1.14.0 which is stable and has many improvements w.r.t. 1.13.2. This issue is rescheduled to 1.16.0

comment:6 by Francesco Casella, 4 years ago

Summary: improper OMEdit behaviour when renaming partial classes' modelsOMEdit does not update diagrams of derived classes

comment:7 by Francesco Casella, 4 years ago

Milestone: 1.16.01.17.0

Retargeted to 1.17.0 after 1.16.0 release

comment:8 by Francesco Casella, 4 years ago

Milestone: 1.17.01.18.0

Retargeted to 1.18.0 because of 1.17.0 timed release.

comment:9 by Adeel Asghar, 4 years ago

Resolution: fixed
Status: newclosed

Fixed with PR#7453.

Note: See TracTickets for help on using tickets.