Opened 7 years ago
Last modified 3 years ago
#4539 assigned enhancement
Vendor specific annotation in MSL
Reported by: | Owned by: | Martin Sjölund | |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | Third-Party Libraries | Version: | |
Keywords: | Cc: |
Description
Vendor specific annotations are not allowed in the MSL (see https://github.com/modelica/Modelica/issues/2332). I am wondering if you have a workflow in order add OpenModelica specific annotations to the MSL.
In the actual trunk version of the MSL there is model Modelica.Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_YD which does not simulate with the default simulation settings in OMEdit. As explained in #4538 the Newton solver is required to work OK. Do have something like a list, where additional OpenModelica specific annotations may be added to MSL Models?
Change History (9)
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Milestone: | Future → 1.13.0 |
---|
I added the fix to https://github.com/OpenModelica/OMLibraries/blob/master/MSL.3.2.2.mos#L85
Do we need it in MSL trunk as well?
comment:3 by , 7 years ago
Yes, we need it in trunk as well.
Additional the same annotation is needed for Modelica.Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Transformer
, both for the MSL 3.2.2 and MSL trunk.
comment:4 by , 7 years ago
Component: | OMEdit → Third-Party Libraries |
---|---|
Owner: | changed from | to
Status: | new → assigned |
comment:6 by , 5 years ago
Milestone: | 1.14.0 → 1.16.0 |
---|
Releasing 1.14.0 which is stable and has many improvements w.r.t. 1.13.2. This issue is rescheduled to 1.16.0
comment:8 by , 4 years ago
Milestone: | 1.17.0 → 1.18.0 |
---|
Retargeted to 1.18.0 because of 1.17.0 timed release.
We do have some patches that we apply to our copy of MSL. The script to apply updates is OK and works rather well, but it does not run automatically. I suppose if I work a bit on it, we could make it run automatically and provide a location to apply OM-specific simulation options where necessary.